Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added configurable runtime.bundle.service.name #131

Merged

Conversation

Projects
None yet
3 participants
@mteodori
Copy link
Member

commented Feb 22, 2019

@igdianov

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

@mteodori 👍

@ryandawsonuk

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Looks good but currently having trouble with pipelines so can't merge right now. http://jenkins.jx.35.240.9.95.nip.io/job/Activiti/job/activiti-build/job/7.0.x/12/console resulted in https://github.com/Activiti/Activiti/pull/2556/files , which is a mixture of the 7.0.x and 7.1.x release trains - more specifically the 7.0.x train made a commit to overwrite a PR on the 7.1.x train. We're working to fix updatebot and get pipelines working again and have submitted a PR for it - jenkins-x/updatebot#73

@mteodori mteodori force-pushed the mteodori-2548-make-rb-service-name-configurable branch from 3102a5b to 6b50d5a Feb 26, 2019

@mteodori mteodori force-pushed the mteodori-2548-make-rb-service-name-configurable branch from 6b50d5a to 3e72575 Feb 26, 2019

@mteodori mteodori requested a review from igdianov Feb 26, 2019

@igdianov

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@mteodori It looks good to me. I will not use Github approval, since it will trigger Mergify to merge this PR until @ryandawsonuk confirms the pipelines are working.

@mteodori

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Now merging this as we have a resolution for Activiti/Activiti#2577

@ryandawsonuk ryandawsonuk merged commit 7dec3bd into develop Feb 27, 2019

4 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ryandawsonuk ryandawsonuk deleted the mteodori-2548-make-rb-service-name-configurable branch Feb 27, 2019

ryandawsonuk pushed a commit that referenced this pull request Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.