Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common chart to rule values with Helm #48

Merged
merged 18 commits into from Feb 14, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+4 −3
Diff settings

Always

Just for now

fix: render common annotation values via printf

  • Loading branch information...
igdianov committed Feb 13, 2019
commit b42e6c72aa6baf96cc42e1a239426bf344d3e766
Copy path View file
@@ -48,13 +48,14 @@ Create default ingress annotations
{{- $noCommon := omit .Values "common" -}}
{{- $overrides := dict "Values" $noCommon -}}
{{- $noValues := omit . "Values" -}}
{{- with merge $noValues $overrides $common -}}
{{- $values := merge $noValues $overrides $common -}}
{{- with $values -}}

{{- range $key, $value := .Values.global.gateway.annotations }}
{{ $key }}: {{ tpl $value . | quote }}
{{ $key }}: {{ tpl (printf "%s" $value) $values | quote }}
{{- end }}
{{- range $key, $value := .Values.ingress.annotations }}
{{ $key }}: {{ tpl $value . | quote }}
{{ $key }}: {{ tpl (printf "%s" $value) $values | quote }}
{{- end }}
{{- if or (eq .Values.global.gateway.http false) .Values.ingress.tls }}
{{ tpl "kubernetes.io/tls-acme: \"true\"" . }}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.