New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename REST endpoint to resume a suspended process #147

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@igdianov
Member

igdianov commented Nov 13, 2018

Fixes Activiti/Activiti#2126

The existing controller used HTTP GET method to accept requests for /suspend and /resume endpoints. This PR changes HTTP method to use POST according to RESTful API best practices.

@igdianov igdianov self-assigned this Nov 13, 2018

@igdianov igdianov requested a review from erdemedeiros Nov 13, 2018

@igdianov igdianov added enhancement wip and removed wip labels Nov 13, 2018

@salaboy salaboy merged commit 955f061 into develop Nov 14, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - pom.xml (Activiti) No new issues
Details

@salaboy salaboy deleted the igdianov-2126-rename-activate-endpoint branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment