Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Events related to different process instances may be collected in one bunch #257

Merged
merged 6 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@igdianov
Copy link
Member

igdianov commented Feb 28, 2019

This PR fixes common problem that maps execution attributes for all events types as well as fixes the issue that mixes execution context attributes for multiple executions in the same transaction.

This test ensures the execution attributes are mapped correctly for subprocesses as well as other events

Unfortunately, I had to remove execution attribute headers from message itself as there is no way to use same headers for different executions for events generated in a single transactions, so message headers will have only common runtime bundle properties...

Fixes Activiti/Activiti#2558

@igdianov igdianov self-assigned this Feb 28, 2019

@igdianov igdianov requested a review from salaboy Feb 28, 2019

@igdianov igdianov added the bug label Feb 28, 2019

@igdianov igdianov changed the title Resolve Events related to different process instances may be collected in one bunch fix: Events related to different process instances may be collected in one bunch Feb 28, 2019

@igdianov igdianov requested review from erdemedeiros and CTI777 Feb 28, 2019

@igdianov igdianov changed the title fix: Events related to different process instances may be collected in one bunch fix: Events related to different process instances may be collected in one bunch [WIP] Feb 28, 2019

@igdianov igdianov force-pushed the igdianov-2558-audit-events-clash branch from 1bb6a19 to 6581f10 Mar 1, 2019

@igdianov igdianov changed the title fix: Events related to different process instances may be collected in one bunch [WIP] fix: Events related to different process instances may be collected in one bunch Mar 1, 2019

@igdianov igdianov force-pushed the igdianov-2558-audit-events-clash branch 2 times, most recently from 0e91bbd to 813f7dd Mar 3, 2019

@erdemedeiros
Copy link
Member

erdemedeiros left a comment

It looks good to me.

@igdianov igdianov force-pushed the igdianov-2558-audit-events-clash branch from 813f7dd to 90bea3a Mar 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #257 into develop will decrease coverage by 0.23%.
The diff coverage is 45.45%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #257      +/-   ##
=============================================
- Coverage      73.41%   73.18%   -0.24%     
  Complexity         5        5              
=============================================
  Files            114      114              
  Lines           1471     1484      +13     
  Branches          42       47       +5     
=============================================
+ Hits            1080     1086       +6     
- Misses           355      359       +4     
- Partials          36       39       +3
Impacted Files Coverage Δ Complexity Δ
...vents/message/AuditProducerRoutingKeyResolver.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...rs/MessageProducerCommandContextCloseListener.java 86.95% <100%> (-1.94%) 0 <0> (ø)
...vents/listeners/ProcessEngineEventsAggregator.java 48.78% <42.85%> (+2.94%) 0 <0> (ø) ⬇️
...essage/ExecutionContextMessageBuilderAppender.java 84.84% <0%> (+3.03%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8a869...a9d96ad. Read the comment docs.

@igdianov igdianov force-pushed the igdianov-2558-audit-events-clash branch from 90bea3a to a9d96ad Mar 15, 2019

@erdemedeiros erdemedeiros removed the request for review from CTI777 Mar 15, 2019

@erdemedeiros erdemedeiros merged commit d2eb9e8 into develop Mar 15, 2019

5 of 7 checks passed

codecov/patch 45.45% of diff hit (target 73.41%)
Details
codecov/project 73.18% (-0.24%) compared to 3e8a869
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - pom.xml (Activiti) No new issues
Details

@erdemedeiros erdemedeiros deleted the igdianov-2558-audit-events-clash branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.