Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AAE-102): support cloud native Bpmn messages #416

Merged
merged 17 commits into from Nov 17, 2019

Conversation

@igdianov
Copy link
Member

igdianov commented Nov 4, 2019

This PR adds support for cloud native Bpmn messages with the help of Message Connector provider. The Message Connector matches catch messages events with messages thrown by process instances using subscription registry and simple key-value message store backend.

Depends on Activiti/activiti-api#151, Activiti/activiti-cloud-api#122, Activiti/Activiti#2971

Part of Activiti/Activiti#1691

image

WIP:

TODO:

  • Message idempotency support
  • Redis backend support
  • Error channel support
  • TTL support
  • Security context authentication support, i.e. RunAs user
  • Refactor MessageCommands to use CommandExecutor endpoint

The following test cases are implemented:

  • Fix duplicate dispatch of StartMessageDeployedEvent via Activiti/Activiti#2986

  • Message Connector Spring Boot Starter module

  • Cancel message event subscription support

  • Interrupting start message event subprocess support

image

  • Non Interrupting start message event subprocess support

image

  • Boundary subprocess message event support

image

  • Boundary task message event support

image

  • Start message event support
  • End throw Message support

image

  • Intermediate Throw -> Catch Message support

image

@igdianov igdianov self-assigned this Nov 4, 2019
@igdianov igdianov requested review from erdemedeiros and mteodori Nov 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #416 into develop will decrease coverage by 0.13%.
The diff coverage is 63.15%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #416      +/-   ##
=============================================
- Coverage      74.52%   74.38%   -0.14%     
  Complexity         5        5              
=============================================
  Files            130      131       +1     
  Lines           1617     1636      +19     
  Branches          48       49       +1     
=============================================
+ Hits            1205     1217      +12     
- Misses           368      374       +6     
- Partials          44       45       +1
Impacted Files Coverage Δ Complexity Δ
...ectors/RabbitCloudConnectorsAutoConfiguration.java 33.33% <ø> (ø) 0 <0> (ø) ⬇️
...vents/listeners/ProcessEngineEventsAggregator.java 39.21% <0%> (-1.61%) 0 <0> (ø)
...ts/configuration/CloudEventsAutoConfiguration.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...ers/CloudMessageSubscriptionCancelledProducer.java 100% <100%> (ø) 0 <0> (?)
...converter/ToCloudProcessRuntimeEventConverter.java 56.25% <50%> (-0.62%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd1de3...0f90428. Read the comment docs.

@igdianov igdianov force-pushed the feat-AAE-102-cloud-native-bpmn-messages branch 3 times, most recently from ab8a266 to 8a4d49e Nov 5, 2019
@igdianov igdianov force-pushed the feat-AAE-102-cloud-native-bpmn-messages branch 4 times, most recently from e0da575 to 173bd3d Nov 12, 2019
@igdianov igdianov force-pushed the feat-AAE-102-cloud-native-bpmn-messages branch from da0f3d5 to 0f90428 Nov 16, 2019
@erdemedeiros erdemedeiros removed the request for review from mteodori Nov 17, 2019
@mergify mergify bot merged commit 281e0f2 into develop Nov 17, 2019
7 of 9 checks passed
7 of 9 checks passed
codecov/patch 63.15% of diff hit (target 74.52%)
Details
codecov/project 74.38% (-0.14%) compared to 5bd1de3
Details
Rule: automatic merge when CI passes and all requested reviews approved (delete_head_branch) Branch `feat-AAE-102-cloud-native-bpmn-messages` has been deleted
Details
Summary 1 rule matches
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - pom.xml (Activiti) No new issues
Details
@mergify mergify bot deleted the feat-AAE-102-cloud-native-bpmn-messages branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.