New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper versioning in submodules #41

Open
ErikBjare opened this Issue Apr 17, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ErikBjare
Copy link
Member

ErikBjare commented Apr 17, 2017

All modules currently have version 0.1 (or, in some few cases, 0.2). I think now would be a good time to finally start versioning them properly. aw-core, aw-server and aw-client specifically. The watchers should also specify which versions they depend on.

I also want to get rid of the dependency_links in all the setup.py's, but that might be postponed to later.

Perhaps we should use something semver-like?

Oh, and also: I don't think we should attempt to keep the versions of the subrepos "in sync" (aw-core and aw-client should not have to have the same version number), but that's up for debate.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ErikBjare

This comment has been minimized.

Copy link
Member

ErikBjare commented May 2, 2017

We should also enable a way to get the current version through the commandline.

The git command git describe --tags would be helpful to do this in a nice way, see this SO thread.

@ErikBjare

This comment has been minimized.

Copy link
Member

ErikBjare commented May 25, 2017

We should probably also remove the aw-core, aw-client and aw-client-js submodules from this repo as they are already referred to by the modules that depend on them (aw-server, aw-watcher-*)

Edit: But how would we do full suite testing in that case?

We might also want to make aw-webui a submodule of aw-server instead. Makes more sense that way. Also ensure a build of aw-server also builds aw-webui properly (could be optional).

  • Make aw-webui a submodule of aw-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment