Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't update web browser data; using a Chromium based browser #503

Closed
corvusdeinanis opened this issue Nov 1, 2020 · 6 comments
Closed
Milestone

Comments

@corvusdeinanis
Copy link

Hey! So I've installed the extension, and I know you don't offer support for browsers other than Firefox and Chrome, but would like to know if there's something wrong on my end. The bucket appears, and is catching data, but when I go to activity, it says "No data". Tried this on Chromium and on Edge (the new version that supports Chrome extensions and runs on the same engine).
Hopefully it's a mistake on my end / it's something you can help me with.

Cheers! Thank you for the amazing app.

@johan-bjareholt
Copy link
Member

We do support Chromium, at least it works on Linux. Maybe it just doesn't work on windows?

The thing is that to support a browser we need to know the appname it has in the window watcher because webextension APIs doesn't allow us to know whether the window is focused or not so we fuse that data to circumvent that (so the window and afk watchers need to run simultaneously too, which they do by default).

Take a look at your appname of your browser and see if it's inside the list below. If it's not it needs to be added and we'll add it so it works in the next version of ActivityWatch. The appname can either be found on the "Top Applications" list in the "Activity" tab or in the window bucket under the "Raw Data" tab.

https://github.com/ActivityWatch/aw-webui/blob/03a1242dc88d562fd390172fd2157cf79ad6abbd/src/queries.ts#L100

@corvusdeinanis
Copy link
Author

Both the Chromium and Edge are already in the list, I'm not sure why it's not working.
The Edge watcher seems active ("aw-watcher-web-edge") but it still says no data.

@johan-bjareholt
Copy link
Member

johan-bjareholt commented Nov 3, 2020

What were the appnames i asked about earlier? Are they exactly "edge.exe" for example or something else?

@ErikBjare
Copy link
Member

ErikBjare commented Nov 3, 2020

It should be noted that msedge.exe was added in April, with v0.9.2 released in May, so it'll be in the next release. Since we don't have chromium.exe in there I assume that could be an issue specific to Chromium on Windows, and it'd have to be added.

But yeah, we need the exact strings to know for sure @TheOrigins.

@corvusdeinanis
Copy link
Author

corvusdeinanis commented Nov 3, 2020

Oh sorry, I misunderstood. Yes, it's chromium.exe. Can you also please add msedge.exe? That's the appname according to the web UI. Thank you so much, both of you!

Edit - According to https://github.com/ActivityWatch/aw-webui/blob/03a1242dc88d562fd390172fd2157cf79ad6abbd/src/queries.ts#L100 , msedge.exe is already there. I just have to wait for the next release in that case then I guess?

@ErikBjare
Copy link
Member

@TheOrigins I added chromium.exe in ActivityWatch/aw-webui@541e99c, and yes, since msedge.exe was already in there it'll be in the next release.

@ErikBjare ErikBjare added this to the v0.10 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants