New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the library to use axios #2

Merged
merged 21 commits into from Apr 1, 2018

Conversation

Projects
None yet
2 participants
@ErikBjare
Copy link
Member

ErikBjare commented Aug 18, 2017

Travis now passes as well, which is nice.

TODO

  • Implement support for the basic APIs
    • Create bucket (needed in aw-watcher-web)
    • List bucket (needed in aw-webui)
    • Delete bucket (needed in aw-webui)
    • List events (needed in aw-webui)
    • Query (needed in aw-webui)
    • Heartbeat (needed in aw-watcher-web)
  • Write tests with mocha

johan-bjareholt added some commits Mar 18, 2018

@johan-bjareholt johan-bjareholt self-assigned this Mar 28, 2018

@ErikBjare

This comment has been minimized.

Copy link
Member

ErikBjare commented Apr 1, 2018

@johan-bjareholt Anything left?

I should probably give fixing Travis another go, but I could do that in another PR at a later time.

@ErikBjare ErikBjare changed the title Started rewriting the library with axios Rewrite the library to use axios Apr 1, 2018

@johan-bjareholt

This comment has been minimized.

Copy link
Member

johan-bjareholt commented Apr 1, 2018

@ErikBjare As far as I know no. Everything is there except for /log which we are not using anymore and I believe is broken now anyway.
Still no heartbeatqueue for the webextension, but that can be made in a seperate PR.

@ErikBjare

This comment has been minimized.

Copy link
Member

ErikBjare commented Apr 1, 2018

Cool, then I'm merging!

@ErikBjare ErikBjare merged commit 9aaaf3f into master Apr 1, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ErikBjare ErikBjare deleted the dev/axios branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment