New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy q2_function decorator (with inspection!) and flood function #58

Merged
merged 3 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@ErikBjare
Copy link
Member

ErikBjare commented May 27, 2018

Added an improved query function decorator that makes Datastore and TNamespace arguments optional, also moved flood here from aw_research.

  • Needs tests for flooding
added an improved query function decorator that makes Datastore and T…
…Namespace arguments optional, also moved flood here from aw_research

@wafflebot wafflebot bot added the review label May 27, 2018

@ErikBjare ErikBjare requested a review from johan-bjareholt May 27, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #58 into master will decrease coverage by 0.25%.
The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   96.12%   95.87%   -0.26%     
==========================================
  Files          29       30       +1     
  Lines        1188     1236      +48     
  Branches      183      194      +11     
==========================================
+ Hits         1142     1185      +43     
- Misses         19       23       +4     
- Partials       27       28       +1
Impacted Files Coverage Δ
aw_transform/__init__.py 100% <100%> (ø) ⬆️
aw_transform/flood.py 86.66% <86.66%> (ø)
aw_analysis/query2_functions.py 88.59% <96.42%> (+1.46%) ⬆️
aw_transform/heartbeats.py 92.3% <0%> (-3.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3689827...9384927. Read the comment docs.

@ErikBjare ErikBjare merged commit 13533e5 into master May 30, 2018

4 of 6 checks passed

codecov/patch 91.52% of diff hit (target 96.12%)
Details
codecov/project 95.87% (-0.26%) compared to 3689827
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the review label May 30, 2018

@ErikBjare ErikBjare deleted the dev/queryfuncintrospectdecorator branch May 30, 2018

@johan-bjareholt

This comment has been minimized.

Copy link
Member

johan-bjareholt commented May 30, 2018

Looked it before you added the tests and it seemed good, the tests looks good aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment