WIP: Ensure Accessibility permissions on macOS

[xylix]

Use AppKit to figure if we have accessibility perms and pyobjc to ask for them.

Still needs to:

• ask with an actual buttoned dialog, for example something with an accept button that links to the correct settings page, a decline button and maybe a learn more link
• If user declines not spam them with prompts, and instead just ask once per app lifetime

[ErikBjare]

Is it possible to add a button on the alert that opens the accessibility settings? I think I've seen that somewhere.

[xylix]

Is it possible to add a button on the alert that opens the accessibility settings? I think I've seen that somewhere.

I found these https://macosxautomation.com/system-prefs-links.html which work as links, but I'm still looking for a way to make the button press "open" the link to the accessibility settings. A standard <a href> link didn't work, but there should be a sane way to link in NSAlert buttons.

Found it. Need to call NSWorkspace.sharedWorkspace().openURL_(NSURL.URLWithString_("x-apple.systempreferences:com.apple.preference.security?Privacy_Accessibility")) on button press.

[lgtm-com]

This pull request introduces 4 alerts when merging 890b6d6 into 25ae699 - view on LGTM.com

new alerts:

• 3 for Unused import
• 1 for Unused local variable

[lgtm-com]

This pull request introduces 1 alert when merging f032ed1 into 25ae699 - view on LGTM.com

new alerts:

• 1 for Unused local variable

[xylix]

Using a native python thread causes a

objc.error: NSInternalInconsistencyException - NSWindow drag regions should only be invalidated on the Main Thread!

Assertion failed: (NSViewIsCurrentlyBuildingLayerTreeForDisplay() != currentlyBuildingLayerTree), function NSViewSetCurrentlyBuildingLayerTreeForDisplay, file /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1894.30.142/AppKit.subproj/NSView.m, line 13568.
fish: 'python aw_watcher_window/__main…' terminated by signal SIGILL (Illegal instruction)

Error. Will need to look into using macOS's own work queue (https://developer.apple.com/documentation/dispatch/1452927-dispatch_get_global_queue?language=objc )

[ErikBjare]

If the issue is that the stuff needs to happen on the main thread, try using the Python multiprocessing module? A bit hacky but will probably work.

…

On Sun, 29 Mar 2020, 17:49 Kerkko Pelttari, ***@***.***> wrote: Using a native python thread causes a ```objc.error: NSInternalInconsistencyException - NSWindow drag regions should only be invalidated on the Main Thread! Assertion failed: (NSViewIsCurrentlyBuildingLayerTreeForDisplay() != currentlyBuildingLayerTree), function NSViewSetCurrentlyBuildingLayerTreeForDisplay, file /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1894.30.142/AppKit.subproj/NSView.m, line 13568. fish: 'python aw_watcher_window/__main…' terminated by signal SIGILL (Illegal instruction)```Error. Will need to look into using macOS's own work queue ( https://developer.apple.com/documentation/dispatch/1452927-dispatch_get_global_queue?language=objc ) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKXDOW67AZCNZR2TDZXBA3RJ5UZ7ANCNFSM4LVTVLEA> .

[xylix]

Seems like it should work. I'll look into it later this week.

[ErikBjare]

Forgot to re-review.

LGTM, feel free to fix up the conflict and merge :)

[ErikBjare]

Woops, just skimmed the diff and missed there were things left to do in the comments. Sorry.

[xylix]

Multiprocessing got rid of the objc.error: NSInternalInconsistencyException - NSWindow drag regions should only be invalidated on the Main Thread! problem. The alert is still a bit wonky (it doesn't "pop up" in the desktop like an alert should, instead it stays in the background and shakes in the macOS dock.

It does now block execution though... which is weird. The window watcher continues execution after I close the modal.

I think I resolved the conflict correctly, will need to see what CI says.

[lgtm-com]

This pull request introduces 1 alert when merging 3ad2af6 into 620b52c - view on LGTM.com

new alerts:

• 1 for Unused local variable

[lgtm-com]

This pull request introduces 1 alert when merging b829e04 into 620b52c - view on LGTM.com

new alerts:

• 1 for Unused local variable

[ErikBjare]

@xylix Looks like all issues have been resolved. Is this ready to merge?

[xylix]

There might have still been some problem, I'll need to manually test on macOS before I can be sure. I'll get that done tomorrow, bit busy today.

[xylix]

@ErikBjare Looks fine to merge, I tested it locally and solved the conflict of the lock file.

[lgtm-com]

This pull request introduces 1 alert when merging 724a3e2 into 8075f16 - view on LGTM.com

new alerts:

• 1 for Unused local variable

[ErikBjare]

@xylix Are the two things in the top comment resolved?

[xylix]

@ErikBjare Oh right. I guess the other one is not, because it is actually pretty hard in recent macOS to set a setting from dialog. Instead the dialog just gives a message and Open Accessibility Options button.

[ErikBjare]

@xylix Should we just leave it as is then and merge?

[xylix]

Yeah I think we should. The other open PR requires more work before it is ready but this one will be an improvement even in it's current form.

[ErikBjare]

Nice! Merging.