Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better user experience when importing buckets #210

Merged
merged 1 commit into from Jul 5, 2020

Conversation

johan-bjareholt
Copy link
Member

@johan-bjareholt johan-bjareholt commented Jun 27, 2020

Instead of being redirected to an empty page the error is now shown on
the same page and the buckets list reloaded

@johan-bjareholt
Copy link
Member Author

@ErikBjare Seems to be some error with the screenshot test?

@ErikBjare
Copy link
Member

ErikBjare commented Jun 29, 2020

@johan-bjareholt Looks like it works as intended and found an error while trying to load the page.

Did you look for the error in your own browser or try to run the e2e tests locally?

@johan-bjareholt
Copy link
Member Author

@ErikBjare Seems to break when you add the "dom" lib to tsconfig in aw-client-js.
It passes anyway if you just pass --skip-js-errors to testcase, but it's better to just fix the root cause.

@ErikBjare
Copy link
Member

ErikBjare commented Jun 30, 2020

Ah, as I mentioned in my late review of your aw-client-js PR then.

And yeah, passing --skip-js-errors would kinda ruin the point of the test :)

@johan-bjareholt
Copy link
Member Author

johan-bjareholt commented Jul 1, 2020

And yeah, passing --skip-js-errors would kinda ruin the point of the test :)

Well, it still runs and passes the test so I wouldn't say pointless. It just ignores runtime errors in the browser.
But it's still a bad idea.

Instead of being redirected to an empty page the error is now shown on
the same page and the buckets list reloaded
@johan-bjareholt
Copy link
Member Author

Reverted the aw-client-js change and moved it into aw-webui which will always have a DOM, so it makes more sense to have it here.

@johan-bjareholt johan-bjareholt merged commit 0038e50 into master Jul 5, 2020
@johan-bjareholt johan-bjareholt deleted the dev/import-ux-enhancement branch July 5, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants