Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split Settings into multiple views #218

Merged
merged 1 commit into from Jul 16, 2020

Conversation

johan-bjareholt
Copy link
Member

Will make it easier to add more settings later, making each section more isolated from each other and therefore easier to grasp what's relevant and what's not.

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but looks reasonable.

@@ -57,7 +57,7 @@ import 'vue-awesome/icons/edit';
export default {
name: 'CategoryEditTree',
props: {
cls: Object,
_class: Object,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the cls -> _class rename?

cls is commonly used in Python (due to it being a reserved keyword). I'd personally prefer to not have underscores in names (unless they are private/local/special), but that's just me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I googled for what cls might mean but couldn't find what it referred to (clear screen in DOS, common language specification, etc. were the results).
I understood it after a while, but it took me way too long.
I've seen klass and _class before so I went with _class.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I guess it's not that clear except in the Python-context:

class A:
    @classmethod
    def f(cls, *args):
        return cls(*args)

src/route.js Outdated Show resolved Hide resolved
@johan-bjareholt johan-bjareholt merged commit 11245d7 into master Jul 16, 2020
@johan-bjareholt johan-bjareholt deleted the dev/settings-split branch July 16, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants