Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support weekly/monthly view in barchart visualization #292

Merged
merged 2 commits into from Jun 10, 2021

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jun 10, 2021

This is pretty great.

Started off trying to implement a 'trends' view (as described in #289), but found it a lot easier to start with just adding week/month support to the barchart.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #292 (ce117f2) into master (4d8e5ee) will decrease coverage by 0.15%.
The diff coverage is 9.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   15.91%   15.76%   -0.16%     
==========================================
  Files          22       24       +2     
  Lines        1062     1142      +80     
  Branches      110      127      +17     
==========================================
+ Hits          169      180      +11     
- Misses        848      912      +64     
- Partials       45       50       +5     
Impacted Files Coverage Δ
src/route.js 0.00% <0.00%> (ø)
src/util/datasets.js 0.00% <0.00%> (ø)
src/util/filters.js 0.00% <0.00%> (ø)
src/store/modules/activity.ts 6.69% <3.03%> (+0.59%) ⬆️
src/util/timeperiod.ts 18.18% <18.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8e5ee...ce117f2. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 10, 2021

This pull request introduces 2 alerts when merging 898883b into 4d8e5ee - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 10, 2021

This pull request fixes 2 alerts when merging ce117f2 into 4d8e5ee - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Template syntax in string literal

@ErikBjare ErikBjare marked this pull request as ready for review June 10, 2021 14:00
@ErikBjare ErikBjare changed the title feat: started working on Trends view feat: support weekly/monthly view in barchart visualization Jun 10, 2021
@ErikBjare ErikBjare merged commit 889a911 into master Jun 10, 2021
@ErikBjare ErikBjare deleted the dev/trends branch June 10, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant