Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activerecord v5 support #85

Merged
merged 6 commits into from Aug 26, 2017
Merged

Conversation

itsmechlark
Copy link
Contributor

@itsmechlark itsmechlark commented Aug 3, 2017

@itsmechlark
Copy link
Contributor Author

In activerecord 5.1 callback under after_commit during destroy is not run since it does not exist in the _callbacks.

@itsmechlark itsmechlark changed the title active_record v5 support activerecord v5 support Aug 3, 2017
@bhgames
Copy link

bhgames commented Aug 3, 2017

@itsmechlark I need this for my 5.1 rails app. Is this branch stable enough to go with?

@itsmechlark
Copy link
Contributor Author

@bhgames. Yes, if you will refer to CI Build #104.

@bplexico
Copy link

@zzak can you merge?

@zzak zzak merged commit 6fabadb into ActsAsParanoid:master Aug 26, 2017
@zzak
Copy link
Contributor

zzak commented Aug 26, 2017

🙇 thank you! should we release this? i wonder if things break w/ v5.2

@itsmechlark
Copy link
Contributor Author

itsmechlark commented Aug 26, 2017

You're welcome, @zzak! Yes, it will help those who need to upgrade to rails v5. Right now, the test against rails edge passed. BTW, thank you for merging this one. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants