Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change conversion rules for ##^ rules -- add max-length="262144" #1556

Closed
2 of 3 tasks
krystian3w opened this issue Dec 21, 2019 · 7 comments
Closed
2 of 3 tasks

Change conversion rules for ##^ rules -- add max-length="262144" #1556

krystian3w opened this issue Dec 21, 2019 · 7 comments

Comments

@krystian3w
Copy link

krystian3w commented Dec 21, 2019

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • AdGuard version:
    • 3.3.4
  • Browser and version:
    • Firefox 71.0
  • Operating system and version:
    • Windows 10 Pro 1909
  • Filters you use in AdGuard:
    • N/A
  • Stealth Mode settings:
    • Disabled
  • Other browser extensions:
    • none

Expected Behavior

Remove pop-up with GDPR/Cookies/Privacy Policy on:

https://www.eobuwie.com.pl/

Actual Behavior

Filter no disable pop-up with GDPR/Cookies/Privacy Policy, so need use ExtendCSS syntax on:

https://www.eobuwie.com.pl/

Screenshots

Screenshot:
obraz

Additional Information

tested filter:

eobuwie.com.pl$$script[tag-content="technologii cookies"]

similar works in uBO 1.24.2 + Firefox 71:

eobuwie.com.pl##^script:has-text(technologii cookies)

Screenshot from uBO logger:
obraz
@Alex-302
Copy link
Member

Alex-302 commented Dec 23, 2019

~It works ~
image
damn, checked in the app:(

@AdamWr
Copy link
Member

AdamWr commented Dec 23, 2019

On my end it doesn't work with Firefox extension (works fine with app, but I think it shouldn't).

I guess that this rule doesn't work, because by default max-length is set to 8192 characters, but in this case this script has about 17000 characters.

This rule works:
eobuwie.com.pl$$script[tag-content="technologii cookies"][max-length="20000"]

@ameshkov
Copy link
Member

max-length was set to 8KB looong time ago so that's okay

The question is what should we do with the automatic rules conversion? uBO, for instance, does not care about script sizes.

When doing the automatic conversion, we could set it to something big, like 64KB for instance.

@ameshkov ameshkov added this to the 3.4 milestone Dec 23, 2019
@ameshkov ameshkov changed the title HTML filtering not work Change the conversion rules for ##^ rules Dec 23, 2019
@ameshkov ameshkov changed the title Change the conversion rules for ##^ rules Change the conversion rules for ##^ rules -- add max-length="262144" Dec 23, 2019
@ameshkov ameshkov changed the title Change the conversion rules for ##^ rules -- add max-length="262144" Change conversion rules for ##^ rules -- add max-length="262144" Dec 23, 2019
@krystian3w
Copy link
Author

does not care about script sizes

only added [min-length="..."]:

https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters#subjectmin-text-lengthn

@krystian3w

This comment has been minimized.

@ameshkov
Copy link
Member

sould be changed to:

homedesign.pl$$div[class="popmake-overlay"][data-popmake="rodo"]

@krystian3w

This comment has been minimized.

krystian3w added a commit to FiltersHeroes/PolishSocialCookiesFiltersDev that referenced this issue Dec 24, 2019
@adguard-bot adguard-bot assigned tvinzz and unassigned maximtop Feb 26, 2020
adguard pushed a commit that referenced this issue Aug 21, 2023
Merge in EXTENSIONS/browser-extension from fix/AG-25078 to master

Squashed commit of the following:

commit e68d33d
Author: Vladimir Zhelvis <v.zhelvis@adguard.com>
Date:   Mon Aug 21 17:27:36 2023 +0300

    update @swc/core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants