Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual download option for the update screen #2299

Closed
Bluscream opened this issue Nov 14, 2018 · 10 comments
Closed

Manual download option for the update screen #2299

Bluscream opened this issue Nov 14, 2018 · 10 comments

Comments

@Bluscream
Copy link

Bluscream commented Nov 14, 2018

Some people have problems with the download manager provided by Android so it would be neat if the "New update available" screen would have a "3 dot menu" in the upper right corner that contains a entry called "Manual download" and opens the url of the download in a browser instead of the download manager.

@TPS
Copy link
Contributor

TPS commented Mar 12, 2019

This, please! I nowadays can almost never successfully complete an update for AG ηightly via built-in download via Android DL manager, but must always download https://static.adguard.com/android/nightly/adguard.apk via MS Edge.

@Revertron
Copy link

Maybe, we just need to download update file by our own code.

@TPS
Copy link
Contributor

TPS commented Mar 12, 2019

Sure, that's what I suggested in #1295 (comment), but that's much more work, so #2299 (this issue 😁) is the quicker workaround.

@ameshkov ameshkov added this to the 3.1 milestone Mar 12, 2019
@ameshkov ameshkov added the UI label Mar 19, 2019
@ameshkov
Copy link
Member

@Revertron @AlikhanAliev

  1. Add "download" button to the context menu
  2. Handle download errors and offer to download manually as an alternative

@nkartyshov nkartyshov assigned nkartyshov and unassigned Revertron Mar 25, 2019
@AlikhanAliev
Copy link

@Revertron @AlikhanAliev

  1. Add "download" button to the context menu
  2. Handle download errors and offer to download manually as an alternative

We can add this button to the context menu, but I do not understand the problem. Guys said me that if we have download error then we have a dialog with "download manually" button too. It is right flow, isn't it?

@ameshkov

@TPS
Copy link
Contributor

TPS commented Mar 26, 2019

As of right now, I don't think AG ever even notices download error for this, so I guess that might be 1st part of №2.

@Revertron
Copy link

@TPS don't you see some toast that an error occurred?

@TPS
Copy link
Contributor

TPS commented Mar 27, 2019

No, it just stops downloading or randomly pauses, like anything else in #597.

@Revertron
Copy link

Added a button to actionbar, you will see it in current nightly 3.0.303 when an update will be available :)

@Bluscream
Copy link
Author

Nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants