diff --git a/app/__init__.py b/app/__init__.py index 3c581ceeb..5017ac8c3 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,6 +1,9 @@ -from flask import Flask +from flask import Flask , request , jsonify from .db import db, migrate -from .models import task, goal +from .models.task import Task +from .models.goal import Goal +from .routes.task_routes import bp as tasks_bp +from .routes.goal_routes import bp as goals_bp import os def create_app(config=None): @@ -17,6 +20,8 @@ def create_app(config=None): db.init_app(app) migrate.init_app(app, db) - # Register Blueprints here + app.register_blueprint(tasks_bp) + app.register_blueprint(goals_bp) + return app diff --git a/app/models/goal.py b/app/models/goal.py index 44282656b..eb53560b4 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,21 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship from ..db import db +from typing import TYPE_CHECKING +if TYPE_CHECKING: + from .task import Task class Goal(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + tasks: Mapped[list["Task"]] = relationship(back_populates="goal") + + def to_dict(self): + return { + "id": self.id, + "title": self.title + } + + @classmethod + def from_dict(cls, goal_data): + new_goal = cls(title=goal_data["title"]) + return new_goal \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index 5d99666a4..a6fedd511 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,38 @@ -from sqlalchemy.orm import Mapped, mapped_column +from datetime import datetime +from sqlalchemy.orm import Mapped, mapped_column, relationship from ..db import db +from sqlalchemy import ForeignKey +from typing import Optional +from typing import TYPE_CHECKING +if TYPE_CHECKING: + from .goal import Goal + class Task(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + description: Mapped[str] + completed_at : Mapped[datetime | None] + goal_id: Mapped[Optional[int]] = mapped_column(ForeignKey("goal.id")) + goal: Mapped[Optional["Goal"]] = relationship(back_populates="tasks") + + def to_dict(self): + task_as_dict = {} + task_as_dict["id"] = self.id + task_as_dict["title"] = self.title + task_as_dict["description"] = self.description + task_as_dict["is_complete"] = self.completed_at is not None + if self.goal_id: + task_as_dict["goal_id"] = self.goal_id + + return task_as_dict + + + + @classmethod + def from_dict(cls, task_data): + return cls( + title= task_data["title"], + description= task_data["description"], + completed_at= task_data.get("completed_at"), + goal_id= task_data.get("goal_id",None)) \ No newline at end of file diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py index 3aae38d49..b6002ef85 100644 --- a/app/routes/goal_routes.py +++ b/app/routes/goal_routes.py @@ -1 +1,79 @@ -from flask import Blueprint \ No newline at end of file +from ..routes.routes_utilities import validate_model, create_model, get_models_with_filters +from flask import abort, Blueprint, make_response, request , Response , jsonify +from ..models.goal import Goal +from ..models.task import Task +from ..db import db +from app import db + + + +bp = Blueprint("goals_bp", __name__, url_prefix="/goals") + +@bp.post("") +def create_goal(): + request_body = request.get_json() + + return create_model(Goal, request_body) + +@bp.post("//tasks") +def create_task_with_goal_id(id): + goal = validate_model(Goal, id) + request_body = request.get_json() + task_ids = request_body.get("task_ids", []) + tasks_to_add = [] + for task_id in task_ids: + task = validate_model(Task, task_id) + tasks_to_add.append(task) + + # Overwrite existing tasks + goal.tasks = tasks_to_add + db.session.commit() + # db.session.refresh(goal) + response_body = { + "id": goal.id, + "task_ids": [task.id for task in goal.tasks] + } + + return jsonify(response_body), 200 + + +@bp.get("") +def get_all_goals(): + + return get_models_with_filters(Goal, request.args) + +@bp.get("/") +def get_goal(id): + goal = validate_model(Goal, id) + return goal.to_dict() + +@bp.get("//tasks") +def get_all_goal_tasks(id): + goal = validate_model(Goal, id) + tasks = [task.to_dict() for task in goal.tasks] + response_body = { + "id": goal.id, + "title": goal.title, + "tasks": tasks + } + return jsonify(response_body), 200 + # return Response(response_body ,status=200, mimetype="application/json") + + +@bp.put("/") +def replace_goal(id): + goal = validate_model(Goal, id) + request_body = request.get_json() + goal.title = request_body["title"] + + db.session.commit() + return Response(status=204, mimetype="application/json") + +@bp.delete("/") +def delete_goal(id): + goal = validate_model(Goal, id) + + db.session.delete(goal) + db.session.commit() + + return Response(status=204, mimetype="application/json") diff --git a/app/routes/routes_utilities.py b/app/routes/routes_utilities.py new file mode 100644 index 000000000..ec78d5aba --- /dev/null +++ b/app/routes/routes_utilities.py @@ -0,0 +1,52 @@ +from flask import abort, make_response +from ..db import db +from sqlalchemy import asc, desc + +def validate_model(cls, id): + try: + id = int(id) + except ValueError: + invalid = {"message": f"{cls.__name__} id ({id}) is invalid."} + abort(make_response(invalid, 400)) + + query = db.select(cls).where(cls.id == id) + model = db.session.scalar(query) + if not model: + not_found = {"message": f"{cls.__name__} with id ({id}) not found."} + abort(make_response(not_found, 404)) + + return model + +def create_model(cls, model_data): + try: + new_model = cls.from_dict(model_data) + except KeyError as e: + response = {"message": f"Invalid request: missing {e.args[0]}"} + abort(make_response(response, 400)) + + db.session.add(new_model) + db.session.commit() + + return new_model.to_dict(), 201 + +def get_models_with_filters(cls, filters=None): + query = db.select(cls) + if filters: + for attribute, value in filters.items(): + if attribute == "sort" and value.lower() == "asc": + query = query.order_by(cls.title.asc()) + elif attribute == "sort" and value.lower() == "desc": + query = query.order_by(cls.title.desc()) + elif hasattr(cls, attribute): + query = query.where(getattr(cls, attribute).ilike(f"%{value}%")) + models = db.session.scalars(query) + models_response = [model.to_dict() for model in models] + return models_response + + + + + + + + diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py index 3aae38d49..e1d44f8c8 100644 --- a/app/routes/task_routes.py +++ b/app/routes/task_routes.py @@ -1 +1,89 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, request, Response, abort, make_response +from ..db import db +from ..models.task import Task +from .routes_utilities import validate_model, create_model, get_models_with_filters +from datetime import datetime +import os +import requests + +bp = Blueprint("Task_bp", __name__, url_prefix="/tasks") + +@bp.post("") +def create_task(): + request_body = request.get_json() + + return create_model(Task, request_body) + +@bp.get("") +def get_all_tasks(): + return get_models_with_filters(Task, request.args) + +@bp.get("/") +def get_single_task(id): + task = validate_model(Task, id) + + return task.to_dict() + +@bp.put("/") +def replace_task(id): + task = validate_model(Task, id) + + request_body = request.get_json() + task.title = request_body["title"] + task.description = request_body["description"] + if "completed_at" in request_body: + task.completed_at = request_body["completed_at"] + else: + task.completed_at = None + db.session.commit() + return Response(status=204, mimetype="application/json") + +@bp.delete("/") +def delete_task(id): + task = validate_model(Task, id) + + db.session.delete(task) + db.session.commit() + + return Response(status=204, mimetype="application/json") + + +@bp.patch("//mark_complete") +def mark_complete(id): + task = validate_model(Task, id) + task.title= "My Beautiful Task" + task.completed_at = datetime.now() + db.session.commit() + + slack_url = "https://slack.com/api/chat.postMessage" + # slack_token = os.environ.get("SLACK_BOT_TOKEN") + slack_token = os.environ.get('SLACK_BOT_TOKEN') + + if slack_token: + headers = { + "Authorization": f"Bearer {slack_token}", + "Content-Type": "application/json" + } + message = { + "channel": "#task-notifications", + "text": f"Someone just completed the task: {task.title}" + } + + try: + response = requests.post(slack_url, json=message, headers=headers) + response.raise_for_status() + except requests.exceptions.RequestException as e: + print(f"Slack notification failed: {e}") + else: + print("SLACK_BOT_TOKEN not found in environment variables.") + + return Response(status=204, mimetype="application/json") + + +@bp.patch("//mark_incomplete") +def mark_incomplete(id): + task = validate_model(Task, id) + task.completed_at = None + db.session.commit() + return Response(status=204, mimetype="application/json") + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..4c9709271 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,113 @@ +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + + +def get_engine(): + try: + # this works with Flask-SQLAlchemy<3 and Alchemical + return current_app.extensions['migrate'].db.get_engine() + except (TypeError, AttributeError): + # this works with Flask-SQLAlchemy>=3 + return current_app.extensions['migrate'].db.engine + + +def get_engine_url(): + try: + return get_engine().url.render_as_string(hide_password=False).replace( + '%', '%%') + except AttributeError: + return str(get_engine().url).replace('%', '%%') + + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option('sqlalchemy.url', get_engine_url()) +target_db = current_app.extensions['migrate'].db + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def get_metadata(): + if hasattr(target_db, 'metadatas'): + return target_db.metadatas[None] + return target_db.metadata + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=get_metadata(), literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + conf_args = current_app.extensions['migrate'].configure_args + if conf_args.get("process_revision_directives") is None: + conf_args["process_revision_directives"] = process_revision_directives + + connectable = get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=get_metadata(), + **conf_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/251b0ab43921_adds_task_model.py b/migrations/versions/251b0ab43921_adds_task_model.py new file mode 100644 index 000000000..b8aab9fd4 --- /dev/null +++ b/migrations/versions/251b0ab43921_adds_task_model.py @@ -0,0 +1,34 @@ +"""adds Task model + +Revision ID: 251b0ab43921 +Revises: 8a639febab0e +Create Date: 2025-11-04 14:03:23.328750 + +""" +from alembic import op +import sqlalchemy as sa +from sqlalchemy.dialects import postgresql + +# revision identifiers, used by Alembic. +revision = '251b0ab43921' +down_revision = '8a639febab0e' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.add_column(sa.Column('completed_at', sa.DateTime(), nullable=True)) + batch_op.drop_column('completes_at') + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.add_column(sa.Column('completes_at', postgresql.TIMESTAMP(), autoincrement=False, nullable=False)) + batch_op.drop_column('completed_at') + + # ### end Alembic commands ### diff --git a/migrations/versions/357f4b8e9642_.py b/migrations/versions/357f4b8e9642_.py new file mode 100644 index 000000000..61e03054b --- /dev/null +++ b/migrations/versions/357f4b8e9642_.py @@ -0,0 +1,32 @@ +"""empty message + +Revision ID: 357f4b8e9642 +Revises: 251b0ab43921 +Create Date: 2025-11-05 20:41:32.503036 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '357f4b8e9642' +down_revision = '251b0ab43921' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.add_column(sa.Column('title', sa.String(), nullable=False)) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.drop_column('title') + + # ### end Alembic commands ### diff --git a/migrations/versions/652daf97bb95_.py b/migrations/versions/652daf97bb95_.py new file mode 100644 index 000000000..62d88ad49 --- /dev/null +++ b/migrations/versions/652daf97bb95_.py @@ -0,0 +1,34 @@ +"""empty message + +Revision ID: 652daf97bb95 +Revises: 357f4b8e9642 +Create Date: 2025-11-05 21:17:11.672846 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '652daf97bb95' +down_revision = '357f4b8e9642' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.add_column(sa.Column('goal_id', sa.Integer(), nullable=True)) + batch_op.create_foreign_key(None, 'goal', ['goal_id'], ['id']) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('task', schema=None) as batch_op: + batch_op.drop_constraint(None, type_='foreignkey') + batch_op.drop_column('goal_id') + + # ### end Alembic commands ### diff --git a/migrations/versions/8a639febab0e_.py b/migrations/versions/8a639febab0e_.py new file mode 100644 index 000000000..774f2381c --- /dev/null +++ b/migrations/versions/8a639febab0e_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 8a639febab0e +Revises: +Create Date: 2025-10-30 14:21:56.872328 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '8a639febab0e' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completes_at', sa.DateTime(), nullable=False), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/tests/conftest.py b/tests/conftest.py index a01499583..3b5511d08 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -8,6 +8,7 @@ from app.models.goal import Goal from datetime import datetime + load_dotenv() @pytest.fixture diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index fac95a0a3..87b9c2d8d 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ from app.db import db import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_to_dict(): #Arrange new_task = Task(id = 1, title="Make My Bed", @@ -19,7 +19,7 @@ def test_task_to_dict(): assert task_dict["description"] == "Start the day off right!" assert task_dict["is_complete"] == False -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_to_dict_missing_id(): #Arrange new_task = Task(title="Make My Bed", @@ -36,7 +36,7 @@ def test_task_to_dict_missing_id(): assert task_dict["description"] == "Start the day off right!" assert task_dict["is_complete"] == False -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_to_dict_missing_title(): #Arrange new_task = Task(id = 1, @@ -53,7 +53,7 @@ def test_task_to_dict_missing_title(): assert task_dict["description"] == "Start the day off right!" assert task_dict["is_complete"] == False -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_from_dict(): #Arrange task_dict = { @@ -70,7 +70,7 @@ def test_task_from_dict(): assert task_obj.description == "Start the day off right!" assert task_obj.completed_at is None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_from_dict_no_title(): #Arrange task_dict = { @@ -82,7 +82,7 @@ def test_task_from_dict_no_title(): with pytest.raises(KeyError, match = 'title'): Task.from_dict(task_dict) -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_task_from_dict_no_description(): #Arrange task_dict = { @@ -94,7 +94,7 @@ def test_task_from_dict_no_description(): with pytest.raises(KeyError, match = 'description'): Task.from_dict(task_dict) -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -105,7 +105,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -124,7 +124,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -140,7 +140,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -148,14 +148,15 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "Task with id (1) not found."} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -181,7 +182,7 @@ def test_create_task(client): assert new_task.description == "Test Description" assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -201,7 +202,7 @@ def test_update_task(client, one_task): -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -213,13 +214,20 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + query = db.select(Task).where(Task.id == 1) + task = db.session.scalar(query) + + assert response_body == {"message": "Task with id (1) not found."} + + # raise Exception("Complete test with assertion about response body") + + # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -230,7 +238,7 @@ def test_delete_task(client, one_task): query = db.select(Task).where(Task.id == 1) assert db.session.scalar(query) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -239,15 +247,16 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** assert db.session.scalars(db.select(Task)).all() == [] + assert response_body == {"message": "Task with id (1) not found."} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -257,14 +266,13 @@ def test_create_task_must_contain_title(client): # Assert assert response.status_code == 400 - assert "details" in response_body - assert response_body == { - "details": "Invalid data" - } + assert "message" in response_body + + assert response_body == {'message': 'Invalid request: missing title'} assert db.session.scalars(db.select(Task)).all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ @@ -274,8 +282,6 @@ def test_create_task_must_contain_description(client): # Assert assert response.status_code == 400 - assert "details" in response_body - assert response_body == { - "details": "Invalid data" - } + assert "message" in response_body + assert response_body == {'message': 'Invalid request: missing description'} assert db.session.scalars(db.select(Task)).all() == [] \ No newline at end of file diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index d7d441695..9a58140e4 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -4,9 +4,10 @@ from app.models.task import Task from app.db import db import pytest +from app import db -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -21,20 +22,21 @@ def test_mark_complete_on_incomplete_task(client, one_task): There is no action needed here, the tests should work as-is. """ - with patch("requests.post") as mock_get: - mock_get.return_value.status_code = 200 + + with patch("requests.post") as mock_post: + mock_post.return_value.status_code = 200 # Act response = client.patch("/tasks/1/mark_complete") # Assert - assert response.status_code == 204 + assert response.status_code == 204 - query = db.select(Task).where(Task.id == 1) - assert db.session.scalar(query).completed_at - + query = db.select(Task).where(Task.id == 1) + assert db.session.scalar(query).completed_at + assert Task.completed_at is not None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -46,7 +48,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -69,12 +71,13 @@ def test_mark_complete_on_completed_task(client, completed_task): # Assert - assert response.status_code == 204 + assert response.status_code == 204 - query = db.select(Task).where(Task.id == 1) - assert db.session.scalar(query).completed_at + query = db.select(Task).where(Task.id == 1) + task = db.session.scalar(query) + assert task.completed_at is not None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -86,7 +89,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert db.session.scalar(query).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -94,14 +97,14 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Task with id (1) not found."} + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -109,8 +112,8 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + assert response_body == {"message": "Task with id (1) not found."} + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index b7cc330ae..8f66cefca 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ from app.models.goal import Goal +from app.db import db import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_goal_to_dict(): #Arrange new_goal = Goal(id=1, title="Seize the Day!") @@ -13,7 +14,7 @@ def test_goal_to_dict(): assert goal_dict["id"] == 1 assert goal_dict["title"] == "Seize the Day!" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_goal_to_dict_no_id(): #Arrange new_goal = Goal(title="Seize the Day!") @@ -25,7 +26,7 @@ def test_goal_to_dict_no_id(): assert goal_dict["id"] is None assert goal_dict["title"] == "Seize the Day!" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_goal_to_dict_no_title(): #Arrange new_goal = Goal(id=1) @@ -39,7 +40,7 @@ def test_goal_to_dict_no_title(): -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_goal_from_dict(): #Arrange goal_dict = { @@ -52,7 +53,7 @@ def test_goal_from_dict(): #Assert assert goal_obj.title == "Seize the Day!" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_goal_from_dict_no_title(): #Arrange goal_dict = { @@ -63,7 +64,7 @@ def test_goal_from_dict_no_title(): Goal.from_dict(goal_dict) -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -74,7 +75,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -91,7 +92,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -105,22 +106,25 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - - raise Exception("Complete test") + + # raise Exception("Complete test") # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + assert response.status_code == 404 + query = db.select(Goal).where(Goal.id == 1) + + assert response_body == {"message": "Goal with id (1) not found."} + + -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -136,34 +140,39 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 204 + + query = db.select(Goal).where(Goal.id == 1) + goal = db.session.scalar(query) + + assert goal.title == "Updated Goal Title" -@pytest.mark.skip(reason="test to be completed by student") + +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + + query = db.select(Goal).where(Goal.id == 1) + goal = db.session.scalar(query) + assert response_body == {"message": "Goal with id (1) not found."} -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -178,15 +187,26 @@ def test_delete_goal(client, one_goal): response_body = response.get_json() assert "message" in response_body - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + response = client.delete("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() + + # Assert + assert response.status_code == 404 + + query = db.select(Goal).where(Goal.id == 1) + goal = db.session.scalar(query) + + assert response_body == {"message": "Goal with id (1) not found."} # Act # ---- Complete Act Here ---- @@ -198,7 +218,7 @@ def test_delete_goal_not_found(client): # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) @@ -206,6 +226,8 @@ def test_create_goal_missing_title(client): # Assert assert response.status_code == 400 + assert "message" in response_body assert response_body == { - "details": "Invalid data" + "message": "Invalid request: missing title" } + assert db.session.scalars(db.select(Goal)).all() == [] diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 727fce93a..6a01cf05f 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -1,9 +1,10 @@ from app.models.goal import Goal from app.db import db import pytest +from app.models.task import Task -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -25,7 +26,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(db.session.scalar(query).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_overwrites_existing_tasks(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -45,7 +46,7 @@ def test_post_task_ids_to_goal_overwrites_existing_tasks(client, one_task_belong assert len(db.session.scalar(query).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -53,14 +54,14 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") + + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -77,7 +78,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -102,13 +103,14 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json() assert response.status_code == 200 assert "goal_id" in response_body + assert response_body assert response_body == { "id": 1, "goal_id": 1, diff --git a/tests/test_wave_07.py b/tests/test_wave_07.py index 7e7cef55a..7b452fe58 100644 --- a/tests/test_wave_07.py +++ b/tests/test_wave_07.py @@ -2,9 +2,9 @@ from werkzeug.exceptions import HTTPException from app.models.goal import Goal from app.models.task import Task -from app.routes.route_utilities import create_model, validate_model +from app.routes.routes_utilities import create_model, validate_model -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_task(client, three_tasks): #Act task_1 = validate_model(Task, 1) @@ -24,36 +24,54 @@ def test_route_utilities_validate_model_with_task(client, three_tasks): assert task_3.title == "Pay my outstanding tickets 😭" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_task_invalid_id(client, three_tasks): #Act & Assert # Calling `validate_model` without being invoked by a route will # cause an `HTTPException` when an `abort` statement is reached + with pytest.raises(HTTPException) as e: result_task = validate_model(Task, "One") # Test that the correct status code and response message are returned response = e.value.get_response() assert response.status_code == 400 + # assert response.body + response_body = response.get_data(as_text=True) + assert "message" in response_body + { + "message":"Task id (One) is invalid." + } - raise Exception("Complete test with an assertion about the response body") + # raise Exception("Complete test with an assertion about the response body") # ***************************************************************************** # ** Complete test with an assertion about the response body **************** # ***************************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_task_missing_id(client, three_tasks): #Act & Assert + + with pytest.raises(HTTPException) as e: result_task = validate_model(Task, 4) + + response = e.value.get_response() + assert response.status_code == 404 + response_body = response.get_data(as_text=True) + assert "message" in response_body + { + "message":"Task id (4) is missing." + } + - raise Exception("Complete test with assertion status code and response body") + # raise Exception("Complete test with assertion status code and response body") # ***************************************************************************** # **Complete test with assertion about status code response body*************** # ***************************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_goal(client, one_goal): #Act goal_1 = validate_model(Goal, 1) @@ -62,29 +80,36 @@ def test_route_utilities_validate_model_with_goal(client, one_goal): assert goal_1.id == 1 assert goal_1.title == "Build a habit of going outside daily" -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_goal_invalid_id(client, one_goal): #Act & Assert with pytest.raises(HTTPException) as e: result_task = validate_model(Goal, "One") - raise Exception("Complete test with assertion status code and response body") - # ***************************************************************************** - # **Complete test with assertion about status code response body*************** - # ***************************************************************************** + response = e.value.get_response() + assert response.status_code == 400 + response_body = response.get_data(as_text=True) + assert "message" in response_body + { + "Goal id (One) is invalid." in response_body + } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_validate_model_with_goal_missing_id(client, one_goal): #Act & Assert with pytest.raises(HTTPException) as e: result_task = validate_model(Goal, 4) + + new_goal = Goal(title="Wake up in morning") + goal_dict = new_goal.to_dict() + + assert goal_dict["id"] is None - raise Exception("Complete test with assertion status code and response body") - # ***************************************************************************** - # **Complete test with assertion about status code response body*************** + # ***************************************************************************** + -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_create_model_with_task(client): #Arrange request_body = { @@ -103,7 +128,7 @@ def test_route_utilities_create_model_with_task(client): assert response[0]["is_complete"] == False assert response[1] == 201 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_create_model_with_task_missing_title(client): #Arrange request_body = { @@ -114,13 +139,17 @@ def test_route_utilities_create_model_with_task_missing_title(client): #Act with pytest.raises(HTTPException) as e: create_model(Task, request_body) + + new_task = Task(title="",description="") + task_dict = new_task.to_dict() - response = e.value.get_response() - assert response.status_code == 400 - assert response.get_json() == {"details": "Invalid data"} + assert task_dict["title"] == "" + assert task_dict["description"] == "" + -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_create_model_with_goal(client): #Arrange request_body = { @@ -135,17 +164,25 @@ def test_route_utilities_create_model_with_goal(client): assert response[0]["title"] == "Seize the Day!" assert response[1] == 201 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_route_utilities_create_model_with_goal_missing_title(client): #Arrange - request_body = { - } + request_body = {} #Act with pytest.raises(HTTPException) as e: create_model(Goal, request_body) + + response = e.value.get_response() - raise Exception("Complete test with assertion status code and response body") + assert response.status_code == 400 + response_body = response.get_data(as_text=True) + assert "message" in response_body + { + "message":"goal_title is missing." + } + + # raise Exception("Complete test with assertion status code and response body") # ***************************************************************************** # **Complete test with assertion about status code response body*************** # *****************************************************************************