New component: text LCD #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…declared without initialization
…y into comp_new_pcf8574
Contributor
Author
|
I created the branch in my copy of the ADL off the branch for the pcf8574. It seems that this pull request contains both the pcf8574 and the new LCD code |
Fabien-Chouteau
requested changes
May 30, 2022
Member
Fabien-Chouteau
left a comment
Fabien-Chouteau
left a comment
There was a problem hiding this comment.
Hi @RREE, thanks for the contribution.
Besides the header this looks good to me.
I guess I can close the other PR for the PCF8574.
| @@ -0,0 +1,39 @@ | |||
| -- | |||
Member
There was a problem hiding this comment.
You should use the same license notice header as the LCD_HD44780 packages.
| @@ -0,0 +1,38 @@ | |||
| -- | |||
Closed
Fabien-Chouteau
requested changes
Jun 1, 2022
Fabien-Chouteau
approved these changes
Jun 14, 2022
Member
|
Thank you @RREE ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add simple text based LCDs based on the HD44780 driver. Almost all text LCD use this or a compatible driver module.
This first version uses a PCF8574 I/O expander via I²C. I can also add a 4bit implementation, but that requires 7 or 8 GPIOs of the controller. That's why I don't use it anymore.
As a prerequisite this patch requires the merge of the aforementioned PCF8574 pull request.