From eb851dff6cf2f23bc87276d2ad970ebf7cc32786 Mon Sep 17 00:00:00 2001 From: Johannes Kliemann Date: Tue, 28 Sep 2021 13:29:51 +0200 Subject: [PATCH] Remove __setitem__ from PyRFLX package API ref #783 --- rflx/pyrflx/package.py | 3 --- tests/unit/pyrflx_test.py | 5 ----- 2 files changed, 8 deletions(-) diff --git a/rflx/pyrflx/package.py b/rflx/pyrflx/package.py index 34fd8aec8e..2151a1a6a7 100644 --- a/rflx/pyrflx/package.py +++ b/rflx/pyrflx/package.py @@ -28,9 +28,6 @@ def set_message(self, key: str, value: MessageValue) -> None: def __getitem__(self, key: str) -> MessageValue: return self.new_message(key) - def __setitem__(self, key: str, value: MessageValue) -> None: - self.set_message(key, value) - def __iter__(self) -> Iterator[MessageValue]: return self.__messages.values().__iter__() diff --git a/tests/unit/pyrflx_test.py b/tests/unit/pyrflx_test.py index 3aa3e17ac9..82ec07991f 100644 --- a/tests/unit/pyrflx_test.py +++ b/tests/unit/pyrflx_test.py @@ -58,11 +58,6 @@ def test_package_iterator(tlv_package: Package) -> None: assert [m.name for m in tlv_package] == ["Message"] -def test_package_set_item(tlv_package: Package) -> None: - msg = Message("TLV::Msg", [], {}) - tlv_package["Msg"] = MessageValue(msg) - - def test_pyrflx_iterator(pyrflx_: PyRFLX) -> None: assert {p.name for p in pyrflx_} == { "Ethernet",