Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

AutoDestroy parameter was never used on loadEmbedded and loadStream #170

Open
wants to merge 1 commit into from

1 participant

@osro

AutoDestroy parameter was never used on loadEmbedded and loadStream.
Which led to a huge memory leak when using these functions.

@osro osro AutoDestroy parameter was never used on loadEmbedded and loadStream
functions (Huge memory leak).

Change-Id: Ibdeac1f247484faf7686f492c05005b3ea8d2213
eaa8962
@moly moly referenced this pull request from a commit in moly/flixel
@moly moly fixed #11, #61, AdamAtomic/flixel#170, AdamAtomic/flixel#221 AutoDest…
…roy parameter in FlxSound loadEmbedded and loadStream does nothing
9f93933
@IQAndreas IQAndreas referenced this pull request from a commit in IQAndreas-testprojects/IQAndreas-flixel
@Dovyski Dovyski Fix FlxSprite.drawLine() incorrect behavior when full transparency se…
…t in color

Fixes #170.
9978d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 4, 2011
  1. @osro

    AutoDestroy parameter was never used on loadEmbedded and loadStream

    osro authored
    functions (Huge memory leak).
    
    Change-Id: Ibdeac1f247484faf7686f492c05005b3ea8d2213
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  org/flixel/FlxSound.as
View
2  org/flixel/FlxSound.as
@@ -257,6 +257,7 @@ package org.flixel
_sound = new EmbeddedSound();
//NOTE: can't pull ID3 info from embedded sound currently
_looped = Looped;
+ autoDestroy = AutoDestroy;
updateTransform();
exists = true;
return this;
@@ -279,6 +280,7 @@ package org.flixel
_sound.addEventListener(Event.ID3, gotID3);
_sound.load(new URLRequest(SoundURL));
_looped = Looped;
+ autoDestroy = AutoDestroy;
updateTransform();
exists = true;
return this;
Something went wrong with that request. Please try again.