New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tilemap scroll #687
Tilemap scroll #687
Conversation
…a new one instead of using prev. anchor point.
…essed while selecting.
… while scrolling with middle mouse button.
This has been fixed. I realized shift+click prior to ANY selection rectangle used (0,0) as the anchor, which I felt wasn't appropriate. |
Thanks for the PR! I'll leave this open for community review and will join in shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @helle253 for the PR. I had a look at it, seems pretty solid.
On the functional side:
- New shift-click multi-tile selection - ✔️
- Original multi-tile selection by mouse drag - ✔️
- New scrolling holding the middle mouse button - ✔️
- Original breakup of the tileset when it fits better horizontally - ✔️
The code is clean and compliant with the style guidelines.
I did notice another minor bug w/ the selection rectangle in the tile palette. When resizing, if tiles within the selection are moved, the rectangle does not reset. It appears to use the first item in the next row as whatever it is pasting for the 'blank' rectangles. This occurs in the master branch, so I don't think it's an issue introduced by me. I'll file an issue when I get a chance to record footage. |
@mfep Thanks for reviewing! Sounds like we'll be ready for merge. I'll have a brief second look, hopefully soon, so we can wrap this up.
👍 |
Merged as per review by @mfep. Thanks everyone! 🙂 |
Related to #630
Added shift+click functionality:
Allows the user to continue editing the selection rectangle in the tile palette after un-clicking. This lets the user modify the selection rectangle at will, without the need to constantly select an 'anchor point' if they want to add a row or column.
Added middle mouse scrolling:
Pressing the middle mouse button now allows the user to dynamically pan around the tile palette window.
These two additional functionalities are atomic. One cannot occur while the other is occurring and vice versa. (this also applies to just left clicking and attempting to scroll)