Missing null check for cluster connections #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a null check in
Dispose(ErrorHandler errorHandler, IDisposable disposable)
, similar to the otherCloseHelper.Dispose
methods.Background:
When I try to connect to a cluster that is not running/responding, I do get the expected AeronTimeoutException from
AeronCluster.Connect()
. But additionally the ErrorHandler is called with a NullReferenceException.The ErrorHandler is called from CloseHelper.Dispose:
The NullReferenceException that is passed to the ErrorHandler has this StackTrace:
at Adaptive.Agrona.CloseHelper.Dispose(ErrorHandler errorHandler, IDisposable disposable)
The issue is that
AsyncConnect.Dispose()
callsCloseHelper.Dispose(errorHandler, ingressPublication)
where ingressPublication might still be null. AdditionallyCloseHelper.Dispose(errorHandler, ingressPublication)
is called twice inAsyncConnect.Dispose()
, which looks unintentional, so I removed this too.