removed the hard coded jwt secret key #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
the hard coded jwt secret key allows an attacker to generate Authentication Tokens and assume the role of the admin without needing the password.
It was replaced with a routine to create a new jwt secret token during every startup. This leads to all previous tokens being invalidated after a restart lxdui.
Changes to be committed:
modified: metadata.py
modified: api/utils/authentication.py