Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not force the use of Safari Icon #78
As far as I can tell, the AdGuard menu application refuses to display app preferences when the Safari Button is not enabled in Safari → Preferences → Extensions. I believe this is an issue, and possibly a security issue that will hinder AdGuard’s adoption.
Steps to reproduce
The Preferences window should open, listing all the available filtering options in the usual format.
A blocking tutorial replaces the window, explaining how the user can (and should, and must) enable the AdGuard for Safari Button. There seems to be no way of bypassing this.
The AdGuard for Safari content blocking extension requires no access to webpages and can therefore be safely enabled by all users in all environments. The Button requires access to the full web page and the user’s complete history, making it more of a security risk in case of a supply chain attack (see CCleaner and others).
Users might legitimately want to use AdGuard for Safari and to edit the Whitelist (and toggle other filter lists) without wanting to use (or needing to use) the Button itself.
Furthermore, the Button is an extra extension to enable in Safari. When memory is constrained or multiple extensions are already running (for whatever reason), users may legitimately want to use AdGuard for Safari all the while keeping its memory footprint as small as possible.
referenced this issue
Nov 9, 2018
In addition to my question here in my point of view it should be enough to enable "only" one (the adguard) safari extension for full functionality and updating filter lists. I don't know how it is right now.
Opening the app itself (manually or on autostart) and the safari icon button should be optional and for customizing / changing settings only.
Thanks for all the hard work. Really appreciated.