Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down menu in query log page is light-colored in dark mode, difficult to read. #5441

Closed
3 tasks done
Aaron-Chua opened this issue Feb 3, 2023 · 5 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@Aaron-Chua
Copy link

Aaron-Chua commented Feb 3, 2023

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Windows

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-b.26

Description

What did you do?

IN DARK MODE:
Visit 'Query Log page', using Edge/Chrome/Firefox (latest release verion).
Click the filter drop-down menu (for example: 'All queries') in the upper right.

Expected result

An easy-to-read drop-down menu with a dark background and light texts, same as 'Settings -> General settings' page.

Actual result

A dropdown menu with a light background and grey/light texts. Hard to read in Edge/Chrome. Invisible in Firefox.

Screenshots (if applicable)

Edge/Chrome
ec

Firefox
f

Additional information

N/A

@Ketan-Agarwal
Copy link

same going on with me
image

@Beet4
Copy link

Beet4 commented Feb 9, 2023

Can confirm, although mine is completely white for non-selected items, so it's impossible to read.

image

Edit: I use Firefox 109.0.1

@GritsanY
Copy link

image
same for me, firefox 109.0.1

adguard pushed a commit that referenced this issue Feb 22, 2023
Updates #5433.
Updates #5439.
Updates #5441.
Updates #5442.

Squashed commit of the following:

commit 8a25010
Merge: a336858 3a0b27e
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Wed Feb 22 13:04:58 2023 +0200

    Merge branch 'master' into 5433-dark-theme-bugs

commit a336858
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Wed Feb 22 11:08:29 2023 +0200

    Review fix

commit 4260601
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Tue Feb 21 15:47:41 2023 +0200

    Fix checkbox, dots bg color in dark mode

commit ea5602f
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Tue Feb 21 13:59:12 2023 +0200

    Fix dark theme bugs
@ainar-g
Copy link
Contributor

ainar-g commented Feb 22, 2023

@sonicprogrammer, @Ketan-Agarwal, @Beet4, @GritsanY, this should be fixed on the Edge channel. Could any of you please check?

@Beet4
Copy link

Beet4 commented Feb 25, 2023

@ainar-g Confirmed working on edge-channel on Firefox Stable 110.0

image

image

image

@ainar-g ainar-g closed this as completed Feb 28, 2023
@ainar-g ainar-g modified the milestones: v0.107.27, v0.107.26 Mar 9, 2023
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#5433.
Updates AdguardTeam#5439.
Updates AdguardTeam#5441.
Updates AdguardTeam#5442.

Squashed commit of the following:

commit 8a25010
Merge: a336858 3a0b27e
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Wed Feb 22 13:04:58 2023 +0200

    Merge branch 'master' into 5433-dark-theme-bugs

commit a336858
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Wed Feb 22 11:08:29 2023 +0200

    Review fix

commit 4260601
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Tue Feb 21 15:47:41 2023 +0200

    Fix checkbox, dots bg color in dark mode

commit ea5602f
Author: Arseny Lisin <a.lisin@adguard.com>
Date:   Tue Feb 21 13:59:12 2023 +0200

    Fix dark theme bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants