Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/FeatureRequest] When you import user filter list, it should accept only text files #1039

Closed
superlex opened this issue Jun 15, 2018 · 1 comment
Assignees
Milestone

Comments

@superlex
Copy link

@superlex superlex commented Jun 15, 2018

Hi,
it's only a little bug (or a little feature request), however it could be important.

Steps to reproduce

  1. Go to AdGuard settings;
  2. click on import to import your filter list.

Expected behavior

It should accept only text files.

Actual behavior

It accepts image files too, and other file types.

Your environment

  • AdGuard AdBlocker extension version: 2.9.2
  • Environment name and version: macOS 10.13.5, Safari 11.1.1
  • Filters you use in AdGuard: default
@ameshkov ameshkov added this to the 3.0 milestone Jul 22, 2018
@aspasskaya aspasskaya added the Bug label Dec 24, 2018
@aspasskaya

This comment has been minimized.

Copy link

@aspasskaya aspasskaya commented Dec 24, 2018

.jpeg file still can be imported in Edge.
Maybe there should be a warning or an error message when a user trying to import non txt file.

https://uploads.adguard.com/assa_9uk0i.png
https://uploads.adguard.com/assa_3ita6.png

@zzebrum zzebrum closed this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.