Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select another Element should be relabled select a different Element #1169

Closed
Samuel12321 opened this issue Dec 9, 2018 · 1 comment
Assignees
Milestone

Comments

@Samuel12321
Copy link

@Samuel12321 Samuel12321 commented Dec 9, 2018

Steps to reproduce

  1. Click on the adguard icon
  2. Select Block ads on this website
  3. Select an ad
  4. Click select another element

Expected behavior

Adguard should allow the user to select an additional ad as well, as "select another element" suggests an additional element as well as the one already selected.

Actual behavior

Previous selected elements are discarded and the user is allowed to select an add to block

If this is intentional the button should be relabled "select a different element", if not there is a bug.

Your environment

  • AdGuard AdBlocker extension version: 2.10.14
  • Environment name and version: Chrome 70.0.3538.110
  • Filters you use in AdGuard: AdGuard Base filter, AdGuard Spyware filter, AdGuard Social Media filter, AdGuard Annoyances filter, Adblock Warning Removal List
  • Any other browser extensions you have installed:
@ameshkov ameshkov added this to the 3.0 milestone Dec 10, 2018
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Dec 10, 2018

That's intended behavior so I guess we should rename the button:
Select another element --> Select a different element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.