Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User filter should be loaded first (before other filters) #117

Closed
ameshkov opened this issue Dec 28, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@ameshkov
Copy link
Member

commented Dec 28, 2015

Steps to reproduce:

  1. Add this rule to the user filter:
lenta.ru#%#AG_onLoad(function() { alert('1'); });
  1. Go to lenta.ru, you'll see alert there
  2. Restart the browser and go to lenta.ru again

Result:
Instead of alert you'll see error in the browser console:

Error executing AG js: ReferenceError: AG_onLoad is not defined

Solution:
Rules from the user filter MUST BE loaded after all other filters are loaded.

@ameshkov ameshkov added the Bug label Dec 28, 2015

@ameshkov ameshkov added this to the 2.1 milestone Dec 28, 2015

Mizzick added a commit that referenced this issue Dec 28, 2015

@Mizzick

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2015

Fixed

@Mizzick Mizzick closed this Dec 28, 2015

Mizzick added a commit that referenced this issue Dec 29, 2015

@atropnikov atropnikov reopened this Jan 11, 2016

@atropnikov

This comment has been minimized.

Copy link
Member

commented Jan 11, 2016

#119
See last comment from ameshkov

adguard pushed a commit that referenced this issue Jan 15, 2016

https://github.com//issues/117
Also updated version to 2.1.2

adguard pushed a commit that referenced this issue Jan 15, 2016

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2016

Fixed:
1d57490
365052d

@ameshkov ameshkov closed this Jan 15, 2016

adguard pushed a commit that referenced this issue Jan 15, 2016

@ameshkov ameshkov changed the title JS rules load order is wrong (in any extension) User filter should be loaded first (before other filters) Jan 19, 2016

ameshkov pushed a commit that referenced this issue Dec 28, 2018

Aleksandr Tropnikov
Merge pull request #117 in EXTENSIONS/browser-extension from feature/…
…redesign-3.0 to feature/redesign

* commit 'b681d5781365fc10da417c796a7c1476de799a29':
  Updated from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.