Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new permissions optional #1220

Closed
ameshkov opened this issue Dec 28, 2018 · 2 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Dec 28, 2018

https://stackoverflow.com/questions/13652969/upgrading-permissions-of-a-chrome-extensions

We need privacy permission for blocking web RTC.

So the idea is to request this permission when user enables this feature or when the user enables stealth mode when blocking webRTC is enabled.

Additionally, we should check that FF extension is not disabled after update.

@ameshkov ameshkov added this to the 3.0 milestone Dec 28, 2018
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 28, 2018

Another issue is Firefox: https://uploads.adguard.com/up04_erpif_Monosnap.png

It does not allow adding privacy to the list of optional permissions so we should test how automatic update looks like.

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Jan 24, 2019

Privacy permissions can be optional only in the chrome.
In order to check if the issue is resolved:

  1. install the extension from the scratch
  2. enable stealth mode
  3. enable Block WebRTC setting
  4. the extension should ask you to grant privacy permissions
@zzebrum zzebrum closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.