Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filter is not saved when exporting settings #1224

Closed
Alex-302 opened this issue Dec 28, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@Alex-302
Copy link
Member

@Alex-302 Alex-302 commented Dec 28, 2018

Steps to reproduce

  1. Import custom filter(URL)
  2. Export settings

Actual behavior

URL of custom filter is absent in export.json
"custom-filters":[]

Your environment

  • AdGuard AdBlocker extension version: 3.01
  • Environment name and version: Chrome
@Alex-302 Alex-302 added the Bug label Dec 28, 2018
@ameshkov ameshkov added this to the 3.0 milestone Dec 28, 2018
@ameshkov ameshkov added the P3: Medium label Dec 28, 2018
@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Jan 24, 2019

In order to test the issue

  1. add some custom filters
  2. the export them
  3. remove filters
  4. import exported settings
  5. check that settings were applied correctly and custom filters appeared with appropriate enable status
@karina-archazh

This comment has been minimized.

Copy link

@karina-archazh karina-archazh commented Feb 5, 2019

In MS Edge import settings doesn't work

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Feb 6, 2019

Export in the edge is not working due to this bug https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8178877/
but you still can check if the issue is resolved in the edge if you copy a string from the exported HTML file to some JSON file.

@zzebrum zzebrum closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.