Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third-party libraries sources #1253

Closed
ameshkov opened this issue Jan 18, 2019 · 4 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Jan 18, 2019

From the Mozilla addon reviewer:

Please take a look at the 3rd party libraries in libs folder and make sure that all links point to the specific tag/release instead of a branch (e.g. "master"). Also note that only stable releases are acceptable (not beta, pre, RC, dev or in your case patched) and that third party CDNs are not considered official source. For more information, refer to https://developer.mozilla.org/en-US/Add-ons/Third_Party_Library_Usage .

Here's what needs to be done:

  1. Get rid of minified libraries completely

  2. Ensure that we use stable releases when it's possible and update sources.txt with the proper links. There are some links to master branches there, this is not acceptable.

  3. Patched libraries and edge cases must be indicated in the sources.txt:

    • nprogress - the same approach, let's fork it, apply our patch, tag the commit and use it.
    • https://github.com/AndersLindman/SHA256 - the same, fork/patch/tag/use
    • https://github.com/inexorabletash/text-encoding
  4. I might be wrong about these, but haven't we moved them all to Assistant?

    • diff_match_patch - it was finally moved to Github so we can try updating it. However, there are no releases there. Let's fork the repo, beautify the JS file, apply our patch, and use it instead of what we use now: https://github.com/google/diff-match-patch
    • https://github.com/cantino/selectorgadget - the same
    • https://github.com/mathiasbynens/CSS.escape
@ameshkov ameshkov added this to the 3.0 milestone Jan 18, 2019
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 22, 2019

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 23, 2019

Ok, more than that, you will need to migrate these changes:
a1f8f8e

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Jan 25, 2019

Aand now we need to get rid of balalaika too (or write something like that from scratch and make it understandable)
5bc3eac

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Feb 5, 2019

Here is nothing to test

@zzebrum zzebrum closed this Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.