Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't search for other rules if first found rule matched with `badfilter` rule #1328

Closed
maximtop opened this issue Mar 13, 2019 · 0 comments
Assignees
Labels
Bug
Milestone

Comments

@maximtop
Copy link
Contributor

@maximtop maximtop commented Mar 13, 2019

This bug was found researching #1325

Description of the bug:
For example russian filter contains rule
||ldkdierujjfmcn.club^$third-party
In the user rule add rule that should mark this rule as badfilter
||ldkdierujjfmcn.club^$third-party,badfilter
and the rule that matches the same request as the first rule
/:\/\/[^\s]+(.club|.com|.online|.ru)\/[^\s]+/$xmlhttprequest,other,domain=hdgo.cc|vio.to

  1. Go to the site:
    http://hdserial.cc/330-doktor-kto-11-sezon-2018-smotret-onlajn-serial-besplatno-hd-720.html
  2. Open filtering log
  3. Press play button
  4. Requests containing this domain https://ldkdierujjfmcn.club/ won't be blocked

If we remove badfilter rule from user filter, turn off all filters, and repeat steps above, we will find that proper requests are blocked.

@maximtop maximtop added this to the 3.0 milestone Mar 13, 2019
@maximtop maximtop self-assigned this Mar 13, 2019
@maximtop maximtop added the Bug label Mar 13, 2019
@zzebrum zzebrum closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.