Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remove X-Client-Data header" should be specific to Google Chrome only #1362

Closed
Spok1 opened this issue Apr 5, 2019 · 14 comments
Closed

"Remove X-Client-Data header" should be specific to Google Chrome only #1362

Spok1 opened this issue Apr 5, 2019 · 14 comments
Assignees
Labels
Milestone

Comments

@Spok1
Copy link

@Spok1 Spok1 commented Apr 5, 2019

Steps to reproduce

  1. Не выставляется настройка убирать x-клиент у запросов! Включил и при переходе и обратно сбрасывается!

Expected behavior

Actual behavior

Screenshot:
Screenshot of the browser console:

Your environment

  • AdGuard AdBlocker extension version: 3.11
  • Environment name and version: (e.g. Chrome 59.0.3071.115) Chrome/71.0.3578.98 Safari/537.36 OPR/58.0.3135.127
  • Filters you use in AdGuard :раздражители, кнопки соц. сетей, русский,английский, аналитика
  • Any other browser extensions you have installed: нет
@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

Здравствуйте, у меня не получилось повторить.
Опишите, пожалуйста подробно действия, которые воспроизводят проблему.

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

Как и было написано, сбрасывается в режиме антитреканга опция скрывать x-клиент! Галку поставил, а она снимается при повторном заходе.

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

"при повторном заходе" - это вы имеете в виду, что вы выключаете браузер?

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

Достаточно просто перейти на другую вкладку к примеру!

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

А какие-то ошибки в консоли есть при этом?

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

В инспекторе?

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

в инструментах разработчика

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

Это ж не страница!😏

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

Это ж не страница!😏

опции экстеншена это страница
у вас есть скайп, телеграмм? может там будет удобнее пообщаться?

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

Я не знаю как в консоли разработчика определить ошибку, там только показывает ошибки запросов URL насколько мне известно!

@Spok1

This comment has been minimized.

Copy link
Author

@Spok1 Spok1 commented Apr 5, 2019

у вас есть скайп, телеграмм? может там будет удобнее пообщаться?

whatsapp есть!

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

можете мне на почту maximtop@gmail.com прислать ваш номер телефона, чтобы тут его не показывать всем

@maximtop

This comment has been minimized.

Copy link
Contributor

@maximtop maximtop commented Apr 5, 2019

This issue is relative to Opera
There is no need to use show Remove X-Client-Data header option for Opera, so we should remove it from options page

@maximtop maximtop added this to the 3.1 milestone Apr 6, 2019
@ameshkov ameshkov changed the title Не выставляется настройка! "Remove X-Client-Data header" should be specific to Google Chrome only Apr 7, 2019
@ameshkov ameshkov added Bug and removed Browser Bug: Opera labels Apr 7, 2019
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Apr 7, 2019

@maximtop actually, it must be shown in Google Chrome only, and not in other chromium-based browsers.

@maximtop maximtop self-assigned this Apr 8, 2019
@zebrum zebrum modified the milestones: 3.1, 3.0 hotfix Apr 11, 2019
@zzebrum zzebrum closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.