Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame scripts and message manager instead of PageMod #138

Closed
ameshkov opened this issue Jan 20, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ameshkov
Copy link
Member

commented Jan 20, 2016

Message gets to content script after window "load" event.
We should think about another way of passing result.

I suggest using messageManager for communications between content scripts and chrome script.

@ameshkov ameshkov added the Firefox label Jan 20, 2016

@ameshkov ameshkov added this to the 2.2 milestone Jan 20, 2016

adguard pushed a commit that referenced this issue Jan 27, 2016

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

@Mizzick @atropnikov
I've made some experiments in a new branch.

It seems that we should get rid of PageMod and use frame scripts everywhere.
It is very important to read documentation first:
https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Message_Manager/Message_manager_overview

@ameshkov ameshkov changed the title Port.emit is very slow in Firefox Nightly Use frame scripts and message manager instead of PageMod Jan 29, 2016

adguard pushed a commit that referenced this issue Feb 1, 2016

adguard pushed a commit that referenced this issue Feb 2, 2016

Mizzick added a commit that referenced this issue Feb 2, 2016

Mizzick added a commit that referenced this issue Feb 2, 2016

Mizzick added a commit that referenced this issue Feb 3, 2016

Mizzick added a commit that referenced this issue Feb 3, 2016

Mizzick added a commit that referenced this issue Feb 3, 2016

Mizzick added a commit that referenced this issue Feb 5, 2016

Mizzick added a commit that referenced this issue Feb 5, 2016

Mizzick added a commit that referenced this issue Feb 5, 2016

Mizzick added a commit that referenced this issue Feb 5, 2016

Mizzick added a commit that referenced this issue Feb 9, 2016

Mizzick added a commit that referenced this issue Feb 9, 2016

atropnikov added a commit that referenced this issue Feb 9, 2016

atropnikov added a commit that referenced this issue Feb 10, 2016

atropnikov added a commit that referenced this issue Feb 12, 2016

atropnikov added a commit that referenced this issue Feb 15, 2016

atropnikov added a commit that referenced this issue Feb 16, 2016

atropnikov added a commit that referenced this issue Feb 29, 2016

@Mizzick Mizzick closed this Feb 29, 2016

ameshkov pushed a commit that referenced this issue Dec 28, 2018

Dmitry Kolyshev
Merge pull request #138 in EXTENSIONS/browser-extension from feature/…
…issues/1007 to feature/redesign

* commit '1c3015f8feeada257fb243d4dc8ecf535a43c48c':
  #1007 categories UI
  #1007 categories UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.