Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $empty modifier #280

Closed
Alex-302 opened this issue Jun 29, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@ameshkov ameshkov added this to the 2.5 milestone Jul 4, 2016
@theseanl

This comment has been minimized.

Copy link
Contributor

@theseanl theseanl commented Nov 5, 2016

We need to take account of this issue AdguardTeam/AdguardForWindows#1360

@ameshkov ameshkov modified the milestones: 2.5, 2.6 Nov 17, 2016
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Jan 10, 2017

I guess it is possible to implement in form of a redirect to data: url

@atropnikov atropnikov self-assigned this Jan 12, 2017
atropnikov added a commit that referenced this issue Jan 12, 2017
atropnikov added a commit that referenced this issue Jan 18, 2017
@atropnikov atropnikov closed this Jan 18, 2017
@theseanl

This comment has been minimized.

Copy link
Contributor

@theseanl theseanl commented May 4, 2017

It seems to be not working in chrome 2.6.3 beta.

On https://www.rapidvideo.com/embed/FEXYFN0CJO with English filter,

2017-05-04 2
Requests to wabxsybclllz.com should not fire.

@theseanl theseanl reopened this May 4, 2017
@Alex-302

This comment has been minimized.

Copy link
Member Author

@Alex-302 Alex-302 commented May 4, 2017

@seanl-adg it works with manually added ||wabxsybclllz.com^$important,empty

image

Which rule should to block that request in your example?

@theseanl

This comment has been minimized.

Copy link
Contributor

@theseanl theseanl commented May 4, 2017

||popads.net/pop.js^$empty,important should block it.
The script snippet initiating the request:

(function () {
    var x = window;
    x['_pop'] = [
        [
            'siteId',
            36286
        ],
        [
            'minBid',
            0
        ],
        [
            'popundersPerIP',
            0
        ],
        [
            'delayBetween',
            0
        ],
        [
            'default',
            false
        ],
        [
            'defaultPerDay',
            0
        ],
        [
            'topmostLayer',
            !0
        ]
    ];
    var q = [
            '//c1.popads.net/pop.js',
            '//c2.popads.net/pop.js',
            '//www.wabxsybclllz.com/r.js',
            '//www.hqaajpaedpux.com/fxw.js',
            ''
        ], v = 0, k, h = function () {
            if ('' == q[v])
                return;
            k = x['document']['createElement']('script');
            k['type'] = 'text/javascript';
            k['async'] = !0;
            var n = x['document']['getElementsByTagName']('script')[0];
            k['src'] = q[v];
            if (v < 2) {
                k['crossOrigin'] = 'anonymous';
            }
            ;
            k['onerror'] = function () {
                v++;
                h();
            };
            n['parentNode']['insertBefore'](k, n);
        };
    h();
}());
@atropnikov

This comment has been minimized.

Copy link
Member

@atropnikov atropnikov commented May 4, 2017

In the case of using $empty modifier, request finishes with status 307 Internal Redirect (it's chrome API behavior) and in this case, onerror callback is fired. I should investigate, can we simulate 200 OK response.

@atropnikov

This comment has been minimized.

Copy link
Member

@atropnikov atropnikov commented May 4, 2017

Or, be more precisely the following error Access to Script at 'data:,' from origin 'null' has been blocked by CORS policy: Invalid response. Origin 'null' is therefore not allowed access. invokes onerror callback.

@ameshkov ameshkov closed this Aug 14, 2017
@theseanl

This comment has been minimized.

Copy link
Contributor

@theseanl theseanl commented Oct 1, 2017

An issue AdguardTeam/AdguardForWindows#1360 (comment) pertains to Windows application is present in browser extensions too. It can be reproduced by following the same steps.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Oct 16, 2017

Filed a new issue:
#879

@ameshkov ameshkov closed this Oct 16, 2017
ameshkov added a commit that referenced this issue Dec 28, 2018
…1167 to feature/redesign

* commit '1ec50009097a5b5fc0ad619f2e068ec2d1d8d437':
  feature/1167 remove unnecessary try catch handlers
  feature/1167
  feature/1167 fix message
  feature/1167
  feature/1167 remove odd classes
  feature/1167
  feature/1167 fix edge get premium
  feature/1167
  feature/1167
  feature/1167
  feature/1167 refactor footer template
  feature/1167
  feature/1167 move notification block to the bottom of widget
  feature/1167
  feature/1167
  feature/1167 fix logic
  feature/1167 close popup get premium notification
  feature/1167 copy notifications module and add template for get premium notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.