Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in set[Restricted|Permitted]Domains method. #391

Closed
atropnikov opened this issue Sep 27, 2016 · 0 comments
Closed

Bug in set[Restricted|Permitted]Domains method. #391

atropnikov opened this issue Sep 27, 2016 · 0 comments
Assignees
Labels
Bug
Milestone

Comments

@atropnikov
Copy link
Member

@atropnikov atropnikov commented Sep 27, 2016

.restrictedDomain and .permittedDomain fields aren't cleaned properly.

Failed test:

var ruleText = "##body";
var rule = new CssFilterRule(ruleText);

rule.setRestrictedDomains(['lenta.ru']);
rule.setRestrictedDomains(['lenta.ru', 'google.com']);

assert.ok(rule != null);
assert.equal(rule.getRestrictedDomains()[0], 'lenta.ru');
assert.equal(rule.getRestrictedDomains()[1], 'google.com');
@atropnikov atropnikov added the Bug label Sep 27, 2016
@Mizzick Mizzick closed this Sep 27, 2016
atropnikov added a commit that referenced this issue Sep 27, 2016
Fix #391 clean up restricted-permitted domain
maximtop pushed a commit that referenced this issue Feb 26, 2019
… to master

* commit 'bb3fc0307ada988fe12dc1dc83732c70a5c8300f':
  fix/1294 add extension modifier to the ignored options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.