Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not block web-sockets on some sites in Firefox and Edge #416

Closed
Alex-302 opened this issue Oct 24, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@Alex-302
Copy link
Member

@Alex-302 Alex-302 commented Oct 24, 2016

Extension version: 2.4.14 (Edge - 2.4.13)
Example sites:

  • kinogo.club
  • kinokrad.co

Related thread
https://forum.adguard.com/index.php?threads/et-code-ru.15323/

@Alex-302 Alex-302 added the Bug label Oct 24, 2016
@ameshkov ameshkov added this to the 2.5 milestone Oct 27, 2016
@Mizzick Mizzick added the Firefox label Nov 9, 2016
@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 9, 2016

@Alex-302 have you tried it?
It seems to be fine on
http://kinogo.club/
http://kinokrad.co/

I can see ads on
http://zserials.tv/zarubezhnye/chance.php
but may be there is no rule for this?

@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 9, 2016

I've found it.
I think we gonna need the same hack as it was done with webkit in #344
cause I can't see the url ws://et-code.ru:8040/904, that was blocked by CSP in chrome, in FF log.

Mizzick added a commit that referenced this issue Nov 9, 2016
@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 9, 2016

Fixed

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Nov 10, 2016

No way, WS connections must be reported to nsIContentPolicy (shouldLoad).

@ameshkov ameshkov reopened this Nov 10, 2016
@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Nov 10, 2016

@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 14, 2016

These requests are not represented on shouldLoad.
But I can see some data:image/png;base64 requests there, I think that's it.
Tried in the latest FF Nightly version.

@ameshkov

This comment has been minimized.

Copy link
Member

@ameshkov ameshkov commented Nov 15, 2016

Prepare a test page where you can reproduce the issue and let's file a new bug report then.

Mizzick added a commit that referenced this issue Nov 17, 2016
@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 17, 2016

The following rule 'ws://et-code.ru:8040' should be added

Mizzick added a commit that referenced this issue Nov 17, 2016
Mizzick added a commit that referenced this issue Nov 17, 2016
Mizzick added a commit that referenced this issue Nov 17, 2016
@Mizzick

This comment has been minimized.

Copy link
Contributor

@Mizzick Mizzick commented Nov 17, 2016

no need on this rule actually
Fixed.

@Mizzick Mizzick closed this Nov 17, 2016
ameshkov added a commit that referenced this issue Nov 17, 2016
maximtop pushed a commit that referenced this issue Apr 12, 2019
… to master

* commit 'c062b8ce8e2b9edced2f761935a66f14961277fd':
  fix/1342 add comment
  fix/1342 update requests view in the filtering when rule is found
  fix/1342 fix issue and add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.