Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari extension does not fully support $generichide rules #437

Closed
ameshkov opened this issue Nov 23, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@ameshkov
Copy link
Member

commented Nov 23, 2016

For instance:
AdguardTeam/AdguardForiOS#255

Here is how we sort them now:

            // Elemhide rules (##) - generic rules
            cssBlockingWide: [],
            // Generic hide exceptions
            cssBlockingWideExceptions: [],
            // Elemhide rules (##) with domain restrictions
            cssBlockingDomainSensitive: [],
            // Elemhide exceptions ($elemhide)
            cssElemhide: [],

The problem is that domain sensitive includes generic rules like ~google.com##banner (no if-domain specified).
So we should change the way we sort rules and add one more group: cssBlockingGenericDomainSensitive

            // Elemhide rules (##) - wide generic rules
            cssBlockingWide: [],
            // Elemhide rules (##) - generic domain sensitive
            cssBlockingGenericDomainSensitive: [],
            // Generic hide exceptions
            cssBlockingWideExceptions: [],
            // Elemhide rules (##) with domain restrictions
            cssBlockingDomainSensitive: [],
            // Elemhide exceptions ($elemhide)
            cssElemhide: [],

@ameshkov ameshkov added this to the 2.5 milestone Nov 23, 2016

@Mizzick Mizzick modified the milestones: 2.6, 2.5 Nov 23, 2016

Mizzick added a commit that referenced this issue Nov 24, 2016

@Mizzick Mizzick closed this Nov 24, 2016

@Mizzick Mizzick removed this from the 2.6 milestone Nov 24, 2016

Mizzick added a commit that referenced this issue Nov 25, 2016

Mizzick added a commit that referenced this issue Nov 25, 2016

ameshkov added a commit that referenced this issue Nov 25, 2016

maximtop pushed a commit that referenced this issue Apr 16, 2019

Maxim Topciu
Merge pull request #437 in EXTENSIONS/browser-extension from fix/1322…
… to master

* commit '61a7950b7fca2284353f3c99b456ef5974ab6f8f':
  fix/1322 show date of last update in the local format && eslint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.