New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build process so that all Adguard's code will be encapsulated into some kind of a reusable API #454

Closed
ameshkov opened this Issue Nov 30, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@ameshkov
Member

ameshkov commented Nov 30, 2016

API:

var adguardApi = {
    start: function(callback) {},
    stop: function(callback) {},
    configure: function(configuration, callback)
};

configuration = {
    filters: [],
    whitelist: [],
    blacklist: [] -- // if blacklist is not undefined, block only those domains
};

@ameshkov ameshkov added this to the 2.6 milestone Nov 30, 2016

atropnikov added a commit that referenced this issue Dec 1, 2016

atropnikov added a commit that referenced this issue Dec 6, 2016

#454
Fix referrer.

atropnikov added a commit that referenced this issue Dec 6, 2016

#454
Fix frame script loading.

atropnikov added a commit that referenced this issue Dec 9, 2016

#454
Removed redundant logging.

atropnikov added a commit that referenced this issue Dec 15, 2016

#454
Fixed CSS.escape polyfill;

atropnikov added a commit that referenced this issue Dec 16, 2016

#454
Added comments.

atropnikov added a commit that referenced this issue Dec 16, 2016

#454
Fixed tab status ‘complete’ update.

atropnikov added a commit that referenced this issue Dec 16, 2016

#454
Added comments.

atropnikov added a commit that referenced this issue Dec 19, 2016

#454
Fixed update context menu and icon;

atropnikov added a commit that referenced this issue Dec 19, 2016

#454
Fixed update context menu and icon;

atropnikov added a commit that referenced this issue Dec 27, 2016

#454
Decreased memory usage.
@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Jan 18, 2017

Member

@ameshkov I think we should remove configuration parameter from the start method. We have configure method for this purpose.

Member

atropnikov commented Jan 18, 2017

@ameshkov I think we should remove configuration parameter from the start method. We have configure method for this purpose.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 18, 2017

Member

@atropnikov as you wish:)

Member

ameshkov commented Jan 18, 2017

@atropnikov as you wish:)

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov
Member

atropnikov commented Jan 18, 2017

@ameshkov When you have time, please check documentation.
https://gist.github.com/atropnikov/b38ae64bac5f9b5e33232ea840884e21

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 18, 2017

Member

@atropnikov you should also explain what is a "filter id". Add a link to the filters.json file for instance.

Member

ameshkov commented Jan 18, 2017

@atropnikov you should also explain what is a "filter id". Add a link to the filters.json file for instance.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 18, 2017

Member

Do we indicate start/stop/configure errors somehow?

Member

ameshkov commented Jan 18, 2017

Do we indicate start/stop/configure errors somehow?

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Jan 18, 2017

Member

I think we can add validation for configuration, this is enough.

Member

atropnikov commented Jan 18, 2017

I think we can add validation for configuration, this is enough.

atropnikov added a commit that referenced this issue Jan 18, 2017

atropnikov added a commit that referenced this issue Jan 18, 2017

atropnikov added a commit that referenced this issue Jan 18, 2017

atropnikov added a commit that referenced this issue Jan 18, 2017

atropnikov added a commit that referenced this issue Jan 23, 2017

#454
Configure filter URLs

atropnikov added a commit that referenced this issue Jan 23, 2017

#454
Configure filter URLs

atropnikov added a commit that referenced this issue Jan 30, 2017

#454
Updated API

@atropnikov atropnikov closed this Feb 7, 2017

atropnikov added a commit that referenced this issue Feb 9, 2017

atropnikov added a commit that referenced this issue Feb 13, 2017

atropnikov added a commit that referenced this issue Mar 2, 2017

#454
Api sample

atropnikov added a commit that referenced this issue Mar 2, 2017

#454
Added filterId to request blocked event details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment