Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSeparate loading of the cosmetic filters and JS filters #512
Assignees
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
Actually, time between request to and response from background page takes from 50 to 300 ms (It was measured without fetching css rules); |
atropnikov
added a commit
that referenced
this issue
Jan 18, 2017
Closed
Closed
adguard
pushed a commit
that referenced
this issue
Sep 17, 2019
… to master * commit 'fe6498868d647b3589a7bb3252cfe520070fa901': fix/1410 deffer update user filter rules in editor if editor cant update fix/1410 fix recursive state switching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we load both types of filters via one request to a background page.
The problem is that loading of the cosmetic filters takes some time (~5-10ms), which also delays JS rules execution. We often need to execute JS rules as soon as possible and even that slight delay might be too much and may allow page own scripts to be executed first.
I suppose, that the only solution to this issue is to separate loading of cosmetic and js filters into two requests.