Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate loading of the cosmetic filters and JS filters #512

Closed
ameshkov opened this issue Jan 14, 2017 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Jan 14, 2017

Currently, we load both types of filters via one request to a background page.

The problem is that loading of the cosmetic filters takes some time (~5-10ms), which also delays JS rules execution. We often need to execute JS rules as soon as possible and even that slight delay might be too much and may allow page own scripts to be executed first.

I suppose, that the only solution to this issue is to separate loading of cosmetic and js filters into two requests.

@ameshkov ameshkov added this to the 2.6 milestone Jan 14, 2017
@atropnikov

This comment has been minimized.

Copy link
Member

@atropnikov atropnikov commented Jan 16, 2017

Actually, time between request to and response from background page takes from 50 to 300 ms (It was measured without fetching css rules);

atropnikov added a commit that referenced this issue Jan 17, 2017
atropnikov added a commit that referenced this issue Jan 17, 2017
atropnikov added a commit that referenced this issue Jan 18, 2017
…pt-loading

#512 Execute js rules as soon as possible
@atropnikov atropnikov closed this Jan 18, 2017
@theseanl theseanl mentioned this issue Mar 2, 2017
@ghajini ghajini mentioned this issue Mar 4, 2017
adguard pushed a commit that referenced this issue Sep 17, 2019
… to master

* commit 'fe6498868d647b3589a7bb3252cfe520070fa901':
  fix/1410 deffer update user filter rules in editor if editor cant update
  fix/1410 fix recursive state switching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.