Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions with $ aren't processed properly #517

Closed
adbuker opened this issue Jan 17, 2017 · 1 comment
Assignees
Labels
Bug
Milestone

Comments

@adbuker
Copy link

@adbuker adbuker commented Jan 17, 2017

@adbuker adbuker added the Bug label Jan 17, 2017
@ameshkov ameshkov added this to the 2.6 milestone Jan 17, 2017
@atropnikov

This comment has been minimized.

Copy link
Member

@atropnikov atropnikov commented Jan 25, 2017

Also, I discovered following things. findShortcut and extractRegexpShortcut can return empty string. For instance: @@||*$domain=lenta.ru and /(.jpg)$/. In this case, our check for shortcut doesn't work, because we assume that shortcut can't be empty, only null.

@atropnikov atropnikov self-assigned this Jan 25, 2017
atropnikov added a commit that referenced this issue Feb 7, 2017
@atropnikov atropnikov closed this Feb 7, 2017
adguard pushed a commit that referenced this issue Oct 1, 2019
…1434 to master

* commit '8a03bbf43af857fd585ed9f7a6f78237e12fb779':
  Version
  Versio
  Update assistant translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.