New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions with $ aren't processed properly #517

Closed
adbuker opened this Issue Jan 17, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@adbuker

adbuker commented Jan 17, 2017

@adbuker adbuker added the Bug label Jan 17, 2017

@ameshkov ameshkov added this to the 2.6 milestone Jan 17, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Jan 25, 2017

Member

Also, I discovered following things. findShortcut and extractRegexpShortcut can return empty string. For instance: @@||*$domain=lenta.ru and /(.jpg)$/. In this case, our check for shortcut doesn't work, because we assume that shortcut can't be empty, only null.

Member

atropnikov commented Jan 25, 2017

Also, I discovered following things. findShortcut and extractRegexpShortcut can return empty string. For instance: @@||*$domain=lenta.ru and /(.jpg)$/. In this case, our check for shortcut doesn't work, because we assume that shortcut can't be empty, only null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment