New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic URL rule, which contains domain name, blocks WS #528

Closed
Alex-302 opened this Issue Jan 25, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@Alex-302
Member

Alex-302 commented Jan 25, 2017

For example - player, which uses WS, is blocked by /flirt4free.
WS address: ws://chat004.vs3.com:42121/chat?token=QldcTF5JZw==
Maybe that's because some wide rules like that blocks:
ws://adguardwebsocket.check /domain. com

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 26, 2017

Member

I guess if we want it to work similarly to other ad blockers, we should remove domain name from the adguardwebsocket.check url.

Member

ameshkov commented Jan 26, 2017

I guess if we want it to work similarly to other ad blockers, we should remove domain name from the adguardwebsocket.check url.

@ameshkov ameshkov added this to the 2.6 milestone Jan 26, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Jan 26, 2017

Contributor

But I think it's very useful now, why do we have to remove this?

Contributor

Mizzick commented Jan 26, 2017

But I think it's very useful now, why do we have to remove this?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jan 26, 2017

Member

It'd be better if AG rules syntax is compatible with all other ad blockers, just to let us all use the same filters.

Member

ameshkov commented Jan 26, 2017

It'd be better if AG rules syntax is compatible with all other ad blockers, just to let us all use the same filters.

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 17, 2017

Member

We could find matching rule only with $websocket modifier. But for this, we have to while rule parsing try to detect 'websocket' rules, like |ws://$domain=4shared.com

Member

atropnikov commented Mar 17, 2017

We could find matching rule only with $websocket modifier. But for this, we have to while rule parsing try to detect 'websocket' rules, like |ws://$domain=4shared.com

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 17, 2017

Contributor

I do not understand you.
So we have the rule /flirt4free, which blocks websocket request from the player. It's correct, isn't it?

Contributor

Mizzick commented Mar 17, 2017

I do not understand you.
So we have the rule /flirt4free, which blocks websocket request from the player. It's correct, isn't it?

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 17, 2017

Member

No, this rule shouldn't block websocket request.

Member

atropnikov commented Mar 17, 2017

No, this rule shouldn't block websocket request.

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 17, 2017

Contributor

Please provide a clear example? How to reproduce this, @Alex-302 ?

Contributor

Mizzick commented Mar 17, 2017

Please provide a clear example? How to reproduce this, @Alex-302 ?

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 21, 2017

Member

Open http://www.flirt4free.com/, disable English filter. Add /flirt4free. rule.
Expected: URL ws://adguardwebsocket.check/flirt4free.com is NOT blocked
Actual: URL ws://adguardwebsocket.check/flirt4free.com is blocked

Member

atropnikov commented Mar 21, 2017

Open http://www.flirt4free.com/, disable English filter. Add /flirt4free. rule.
Expected: URL ws://adguardwebsocket.check/flirt4free.com is NOT blocked
Actual: URL ws://adguardwebsocket.check/flirt4free.com is blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment