Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Export Extension Filters #532

Closed
192848 opened this issue Jan 27, 2017 · 9 comments
Closed

Can't Export Extension Filters #532

192848 opened this issue Jan 27, 2017 · 9 comments
Assignees

Comments

@192848
Copy link

192848 commented Jan 27, 2017

id 1291087
Current version 2.5.11
Chrome\FF

Steps to reproduce:

  1. Go to Adguard settings
  2. Go to User filter section
  3. Add few rules to User filter list
  4. Press "Export" button

Result: export file wasn't downloaded

image

image

@192848 192848 added the Bug label Jan 27, 2017
@ameshkov ameshkov added this to the 2.5 Firefox Hotfix milestone Jan 27, 2017
@atropnikov
Copy link
Member

@VGavrish rules with $replace modifier are not supported by the browser extension. That's why you don't see it on export page.

@dallas7
Copy link

dallas7 commented Jan 30, 2017

In the email reply to my initial 01/26 submission as Ticket ID: GPC-127-17309, it said "We were able to reproduce the issue at our end and filed the task for developers...Once resolved, it will be closed and marked with ‘Fixed’ label."
I see here only "closed." So, no resolution?
In my submission I reported the download failure occurs with both the Whitelist and User filter exports, the former having been left out of "steps to reproduce" above.
Also left out was my mention that the exports work A-OK in v49 and v50. The failure appeared with v51.
I set up Google Chrome imported my User filters, added another filter and exported OK.
Finally, the text "$replace" in my User filters does not exist and it's not that $replace is not seen on the export page - nothing is seen.
As well, in my Whitelist are five domain names, www.something.com - nothing fancy.
• What now?
Thank you.

P.S. As the MP4 video I submitted originally is not a supported file type here, I attached it to a ticket email (support.en) reply, subject [#GPC-127-17309]: Can't Export Extension Filters.

@Eugene-Savenko
Copy link
Member

Replied through support.

@dallas7
Copy link

dallas7 commented Jan 31, 2017

Replied through support: (Thank you.)
"The task has been closed because the extension simply does not support rules with $replace modifier, that why you don't see them while exporting."

EXCEPT THAT THE ||allmusic...$replace...important RULE SHOWN IN THE DETAIL IMAGE IN THE FIRST POST ABOVE IS AN EXAMPLE INVENTED BY VGAVRISH.

The text $replace DOES NOT EXIST in my user filters. That modifier is not in use.

The export failure I reported in Ticket ID: GPC-127-17309 occurs as well when exporting the white list.

I submit a screen shot as evidence. The page remains blank indefinitely.

adguardwlistexportfail

@atropnikov
Copy link
Member

Hello, @dallas7. Sorry for the misunderstanding and thank you for your cooperation. I investigated your problem, the corresponding issue is #541. Unfortunately, we cannot solve this problem completely. We are going to release a new version that fixes this problem (with some restrictions) and some performance issues soon.

@dallas7
Copy link

dallas7 commented Feb 1, 2017

No problem. Thanks for re-evaluating this discussion. I understand the extension is free and did not expect support to rise to the level of the licensed product. Just that my report be understood.

But as a user, a minority in your customer base no doubt, who uses the "Block ads in this website" function (I have 42 rules) it's likely some one else will surely run into it, too.

There's no problem importing, so I can work around it by pasting the new rule from the settings page into the last-good exported file.

I read in the forum that v2.6 is in the works and I look forward to it.

Cheers.

@Bohdan-SUP
Copy link

@atropnikov

The same thing happens in Chrome with Adguard 2.5.11 with a rule like $$script[tag-content="banner"] - it won't get exported.

Is this by design?

@Alex-302
Copy link
Member

@Bohdan-SUP $$ rules are not supported by browser extensions

@ameshkov
Copy link
Member

Should we allow adding them?

adguard pushed a commit that referenced this issue Oct 15, 2019
… to master

* commit 'cfdf4c6a164de7d1faf9bef3ae8783c5e6734ada':
  Fix capitalization of GitHub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants