New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while parsing rules with $replace modifier #559

Closed
atropnikov opened this Issue Feb 21, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@atropnikov
Member

atropnikov commented Feb 21, 2017

||goodgame.ru/*.php?script=*vastInlineBannerTypeHtml$important,replace=/(<VAST[\s\S]*?>)[\s\S]*<\/VAST>/\$1<\/VAST>/

Extension doesn't correctly parse the rule above

Unknown option: 1<\/VAST>/

Extension hasn't supported this type of rule yet, but anyway it is incorrect behavior.

@atropnikov atropnikov added this to the 2.6 milestone Feb 21, 2017

@Mizzick Mizzick closed this in f115a16 Feb 21, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Feb 27, 2017

Member

It isn't a correct fix. We should start looking from the end of the rule and find non-escaped $ sign. You can view how it is done in java code.

Member

atropnikov commented Feb 27, 2017

It isn't a correct fix. We should start looking from the end of the rule and find non-escaped $ sign. You can view how it is done in java code.

@atropnikov atropnikov reopened this Feb 27, 2017

Mizzick added a commit that referenced this issue Feb 27, 2017

@Mizzick Mizzick closed this Feb 27, 2017

atropnikov added a commit that referenced this issue Mar 2, 2017

atropnikov added a commit that referenced this issue Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment