New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Storage size limit issue #566

Closed
atropnikov opened this Issue Feb 27, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@atropnikov
Member

atropnikov commented Feb 27, 2017

Edge's browser.storage is limited to 1MB per value.

As a workaround for this issue, we use localStorage for saving rules. The problem is that if there're too many subscriptions enabled, we get the QuotaExceededError exception as the localStorage has an overall size limit of 5MB.

We should do following:

  1. Split values that are over a limit so they can be stored to storage.local.
  2. Check that with the unlimitedStorage permission in the manifest, quota for storage.local is ignored.
  3. Check fixed version in Anniversary and Insider builds.

Note: If the solution above solves the problem, don't forget to move rules from localStorage to storage.local on update.

@atropnikov atropnikov added this to the 2.6 milestone Feb 27, 2017

@ameshkov ameshkov changed the title from Edge Storage problem to Edge Storage limitation issue Feb 27, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 27, 2017

Member

Worth noticing, that before Anniversary update there was an issue with the browser.storage: it was ignoring the unlimitedStorage permission, hence limited to 5MB.

Member

ameshkov commented Feb 27, 2017

Worth noticing, that before Anniversary update there was an issue with the browser.storage: it was ignoring the unlimitedStorage permission, hence limited to 5MB.

@ameshkov ameshkov changed the title from Edge Storage limitation issue to Edge Storage size limit issue Feb 27, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 20, 2017

Contributor

According to docs, there is no more limit of 1 MB per value.

Allows storage.local to have unlimited storage (depending on system resources) instead of 5MB. The max storage per key value pair is also increased from 5MB to unlimited (depending on system resources).

https://docs.microsoft.com/en-us/microsoft-edge/extensions/api-support/supported-manifest-keys

Contributor

Mizzick commented Mar 20, 2017

According to docs, there is no more limit of 1 MB per value.

Allows storage.local to have unlimited storage (depending on system resources) instead of 5MB. The max storage per key value pair is also increased from 5MB to unlimited (depending on system resources).

https://docs.microsoft.com/en-us/microsoft-edge/extensions/api-support/supported-manifest-keys

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 20, 2017

Member

Is it so in the current stable version of Edge?

Member

ameshkov commented Mar 20, 2017

Is it so in the current stable version of Edge?

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 20, 2017

Contributor

Nope in current version the limit exists.

Contributor

Mizzick commented Mar 20, 2017

Nope in current version the limit exists.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 20, 2017

Member

Argh:(

What if we continue using localStorage for the stable version and switch to using storage for newer Edge?

Member

ameshkov commented Mar 20, 2017

Argh:(

What if we continue using localStorage for the stable version and switch to using storage for newer Edge?

@ameshkov ameshkov assigned atropnikov and unassigned Mizzick Mar 22, 2017

atropnikov added a commit that referenced this issue Mar 28, 2017

atropnikov added a commit that referenced this issue Mar 28, 2017

@atropnikov atropnikov closed this Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment