New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge browser.windows.getAll issue in the Insider Fast ring build #569

Closed
ameshkov opened this Issue Feb 28, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@ameshkov
Member

ameshkov commented Feb 28, 2017

@atropnikov we should push the update ASAP.

Bug description:

Hope you’re well. I wanted to let you know of a regression to browser.windows.getAll() that was introduced on an internal build of Windows recently which breaks AdGuard’s initialization. The method signature was incorrectly changed so that it no longer accepts a null getInfo object.

As a result, would it be possible for you to change the call to getAll in background-page.js (around line 478) from

browser.windows.getAll(function (windows) {

to

browser.windows.getAll({}, function (windows) {

I made this change locally and verified that AdGuard started to work again as expected. We’re working to get this resolved on our end, but given where we are in our release cycle, it’s unclear whether it will make the bar for fixing before the Creators Update launches.

atropnikov added a commit that referenced this issue Mar 1, 2017

atropnikov added a commit that referenced this issue Mar 1, 2017

@atropnikov atropnikov closed this Mar 15, 2017

atropnikov added a commit that referenced this issue Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment