New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error with generichide implementation #574

Closed
vozersky opened this Issue Mar 9, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@vozersky
Member

vozersky commented Mar 9, 2017

Example:

Search ads are not blocked in Yahoo.

  1. Open https://search.yahoo.com
  2. Type in a search request like "buy sneakers".

Result: Search ads at the right side of the page are not blocked.

@vozersky vozersky added the Chromium label Mar 9, 2017

@vozersky vozersky added this to the 2.6.0 Beta milestone Mar 9, 2017

@vozersky vozersky changed the title from Search ads are not blocked in Yahoo to Possible error with elemhide implementation Mar 9, 2017

@vozersky vozersky changed the title from Possible error with elemhide implementation to Possible error with generichide implementation Mar 9, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 14, 2017

Member

English filter contains @@||search.yahoo.com^$generichide rule, that's why search ads at the right side are not blocked. @Alex-302 Please, check it.

Member

atropnikov commented Mar 14, 2017

English filter contains @@||search.yahoo.com^$generichide rule, that's why search ads at the right side are not blocked. @Alex-302 Please, check it.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 14, 2017

Member

I wonder why do the EasyList guys even need this rule?

search.yahoo.com##.searchRightMiddleAds
search.yahoo.com##.searchCenterTopAds
search.yahoo.com##.searchRightBottomAds
Member

ameshkov commented Mar 14, 2017

I wonder why do the EasyList guys even need this rule?

search.yahoo.com##.searchRightMiddleAds
search.yahoo.com##.searchCenterTopAds
search.yahoo.com##.searchRightBottomAds
@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Mar 14, 2017

Member

search.yahoo.com##.searchRightMiddleAds
search.yahoo.com##.searchCenterTopAds
search.yahoo.com##.searchRightBottomAds

added

Member

Alex-302 commented Mar 14, 2017

search.yahoo.com##.searchRightMiddleAds
search.yahoo.com##.searchCenterTopAds
search.yahoo.com##.searchRightBottomAds

added

Alex-302 added a commit to AdguardTeam/AdguardFilters that referenced this issue Mar 14, 2017

@atropnikov atropnikov closed this Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment