New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsing security doesn't work #580

Closed
vozersky opened this Issue Mar 9, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@vozersky
Member

vozersky commented Mar 9, 2017

  1. Enable safebrowsing.
  2. Open any page from safebrowsing filter, for example: http://www.internetbadguys.com/
    Result: Adguard doesn't show a Browsing security warning.

Also, got this in console log once:

2017-03-09T13:58:37.504Z: Error response status 502 received from safebrowsing lookup server.
log.js (71,9)
HTTP502: BAD GATEWAY - The server, while acting as a gateway or proxy, received an invalid response from the upstream server it accessed in attempting to fulfill the request.
(XHR)GET - https://sb.adtidy.org/safebrowsing-lookup-hash.html?prefixes=6C9B2024%2F3AA8C51F

@vozersky vozersky added Bug Edge labels Mar 9, 2017

@vozersky vozersky added this to the 2.6.0 Beta milestone Mar 9, 2017

@MarDarkXT

This comment has been minimized.

Show comment
Hide comment
@MarDarkXT

MarDarkXT Mar 9, 2017

It works for me.
browsersecurity

MarDarkXT commented Mar 9, 2017

It works for me.
browsersecurity

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 9, 2017

Member

@vozersky that's just @mmigi was re-deploying safebrowsing server.

Member

ameshkov commented Mar 9, 2017

@vozersky that's just @mmigi was re-deploying safebrowsing server.

@MarDarkXT

This comment has been minimized.

Show comment
Hide comment
@MarDarkXT

MarDarkXT Mar 9, 2017

@ameshkov I think he is right. It only worked the first time. Now every time I access the page it doesn't work anymore.

MarDarkXT commented Mar 9, 2017

@ameshkov I think he is right. It only worked the first time. Now every time I access the page it doesn't work anymore.

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 9, 2017

Member

@ameshkov I know he was. Still doesn't work for me though.

@MarDarkXT are you on v2.6.0?

Member

vozersky commented Mar 9, 2017

@ameshkov I know he was. Still doesn't work for me though.

@MarDarkXT are you on v2.6.0?

@vozersky vozersky added the Firefox label Mar 9, 2017

@MarDarkXT

This comment has been minimized.

Show comment
Hide comment
@MarDarkXT

MarDarkXT Mar 10, 2017

@vozersky No on 2.5.18, but it still happens on this version too. For the first visit it works. After that it never works.

MarDarkXT commented Mar 10, 2017

@vozersky No on 2.5.18, but it still happens on this version too. For the first visit it works. After that it never works.

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 10, 2017

Member

@MarDarkXT well, if you choose "advanced" -> "proceed anyway" on some website, then your choice is stored in browser cache and you will not see the warning again until you clean the cache

Member

vozersky commented Mar 10, 2017

@MarDarkXT well, if you choose "advanced" -> "proceed anyway" on some website, then your choice is stored in browser cache and you will not see the warning again until you clean the cache

@MarDarkXT

This comment has been minimized.

Show comment
Hide comment
@MarDarkXT

MarDarkXT Mar 10, 2017

@vozersky No I didn't. It is like this.

  1. Open browser
  2. Visit GitHub issue
  3. Click on link
  4. Tab opens and warning is shown
  5. Close tab
  6. Click on link again. It will always show the page until I close the browser.

MarDarkXT commented Mar 10, 2017

@vozersky No I didn't. It is like this.

  1. Open browser
  2. Visit GitHub issue
  3. Click on link
  4. Tab opens and warning is shown
  5. Close tab
  6. Click on link again. It will always show the page until I close the browser.
@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 13, 2017

Contributor

Works fine for me.

Contributor

Mizzick commented Mar 13, 2017

Works fine for me.

@atropnikov atropnikov self-assigned this Mar 14, 2017

atropnikov added a commit that referenced this issue Mar 15, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 15, 2017

Member

In Edge browser, for updating tab's URL we use content script due to some restrictions, that are described here: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/update#Parameters
The problem may appear when content script have not been loaded yet.

Member

atropnikov commented Mar 15, 2017

In Edge browser, for updating tab's URL we use content script due to some restrictions, that are described here: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/update#Parameters
The problem may appear when content script have not been loaded yet.

@atropnikov atropnikov closed this Mar 15, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 15, 2017

Member

For Firefox browser, this task is resolved with #583

Member

atropnikov commented Mar 15, 2017

For Firefox browser, this task is resolved with #583

atropnikov added a commit that referenced this issue Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment