New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard settings window is not shown in private mode #658

Closed
Anoop2609 opened this Issue Apr 26, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@Anoop2609

Anoop2609 commented Apr 26, 2017

Firstly it happen i think it just a malfunction but now it is happening like "n" number of time, just look at the image . I am using Firefox 53.0(64 bit) and adguard 2.6.1 beta. New firefox extension is little slow also, size of the extension is 3.78MB it is too much because the your competitor ublock origin size is just 1.67MB and it also work very smooth but i love adguard so i just want to make it best adblocker
screenshot 1

@atropnikov atropnikov self-assigned this Apr 26, 2017

@vozersky vozersky added the Bug label Apr 26, 2017

@vozersky vozersky changed the title from Adgurad setting box is not showing to Adguard settings window is not showing in incognito mode Apr 26, 2017

@vozersky vozersky added the Firefox label Apr 26, 2017

@vozersky vozersky changed the title from Adguard settings window is not showing in incognito mode to Adguard settings window is not shown in private mode Apr 26, 2017

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Apr 26, 2017

Member

Reproduced.
@Anoop2609 thanks a lot for reporting it!

Member

vozersky commented Apr 26, 2017

Reproduced.
@Anoop2609 thanks a lot for reporting it!

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Apr 27, 2017

Member

@Anoop2609 about the extension size: we do actually include English filter in extension file itself (And it's about 2mb). I don't see a problem here though.

Member

vozersky commented Apr 27, 2017

@Anoop2609 about the extension size: we do actually include English filter in extension file itself (And it's about 2mb). I don't see a problem here though.

atropnikov added a commit that referenced this issue Apr 27, 2017

@ameshkov ameshkov added this to the 2.6 milestone May 2, 2017

atropnikov added a commit that referenced this issue May 2, 2017

atropnikov added a commit that referenced this issue May 2, 2017

Merge pull request #660 from AdguardTeam/feature/issues/658-popup-webext
Adguard settings window is not shown in private mode #658

@atropnikov atropnikov closed this May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment