New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$content modifier works as URL exclusion #719

Closed
Alex-302 opened this Issue May 31, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Alex-302
Member

Alex-302 commented May 31, 2017

This modifier must be ignored by extension.
image

@Alex-302 Alex-302 added the Bug label May 31, 2017

@atropnikov atropnikov added this to the 2.6 milestone May 31, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick May 31, 2017

Contributor

The list of ignored options:

UrlFilterRule.ignoreOptions = {
        // Deprecated modifiers
        'BACKGROUND': true,
        '~BACKGROUND': true,
        // Unused modifiers
        'COLLAPSE': true,
        '~COLLAPSE': true,
        '~DOCUMENT': true,
        // http://adguard.com/en/filterrules.html#advanced
        'CONTENT': true
    };

So this option $content is ignored, but the rule remains working.

Contributor

Mizzick commented May 31, 2017

The list of ignored options:

UrlFilterRule.ignoreOptions = {
        // Deprecated modifiers
        'BACKGROUND': true,
        '~BACKGROUND': true,
        // Unused modifiers
        'COLLAPSE': true,
        '~COLLAPSE': true,
        '~DOCUMENT': true,
        // http://adguard.com/en/filterrules.html#advanced
        'CONTENT': true
    };

So this option $content is ignored, but the rule remains working.

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Jun 1, 2017

Member

@Mizzick I think we should parse $CONTENT modifier as others. If we don't parse it, white list rules with this modifier will contain "allow all" permitted content type.

Member

atropnikov commented Jun 1, 2017

@Mizzick I think we should parse $CONTENT modifier as others. If we don't parse it, white list rules with this modifier will contain "allow all" permitted content type.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jun 1, 2017

Member

A rule with a single $content modifier should be ignored.
A rule with multiple modifiers which includes $content should continue to work.

Member

ameshkov commented Jun 1, 2017

A rule with a single $content modifier should be ignored.
A rule with multiple modifiers which includes $content should continue to work.

Mizzick added a commit that referenced this issue Jun 6, 2017

Mizzick added a commit that referenced this issue Jun 6, 2017

Mizzick added a commit that referenced this issue Jun 6, 2017

@atropnikov atropnikov closed this in 237da1b Jun 7, 2017

atropnikov added a commit that referenced this issue Jun 7, 2017

Mizzick added a commit that referenced this issue Jun 14, 2017

Mizzick added a commit that referenced this issue Jun 15, 2017

Mizzick added a commit that referenced this issue Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment